Conversation
Contributor
There was a problem hiding this comment.
you should always return a promise. return error ? Promise.reject(err) : Promise.resolve(...)
Contributor
There was a problem hiding this comment.
jk i didn't look up. hahaha
Contributor
Author
There was a problem hiding this comment.
Yeah, the name probably wasn't great. I just changed it from error to rejected to match expectations about its type.
dgraham
added a commit
that referenced
this pull request
Oct 15, 2014
Allow body to be consumed only once
Contributor
Author
|
@annevk I'm working on a branch where the body is resolved later than the initial response promise. Right now, it's resolving the response in an XHR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch enforces Section 5.2 of the spec, which describes how the
bodyUsedattribute restricts consuming the body more than once./cc @annevk on spec compliance here