Support more Inform6 attributes#527
Conversation
|
Thanks for the PR. I will take a look as soon as I can.
…On Thu, Oct 28, 2021, 6:57 AM michaelbub ***@***.***> wrote:
C# isn't my first or second language. Which is to say I didn't know what I
was doing on many different levels (including perhaps the interpretation of
all the "Thing" properties).
This might not be "production-ready" code, still I'd wanted to publish
this.
------------------------------
You can view, comment on, or merge this pull request online at:
#527
Commit Summary
- Support more Inform6 attributes
<5a11f68>
File Changes
(1 file <https://github.com/JasonLautzenheiser/trizbort/pull/527/files>)
- *M* Export/Languages/Inform6Exporter.cs
<https://github.com/JasonLautzenheiser/trizbort/pull/527/files#diff-62765e582eaa01ddf59bea3682787def3cb0ca82ac6d27b48472764541b74293>
(52)
Patch Links:
- https://github.com/JasonLautzenheiser/trizbort/pull/527.patch
- https://github.com/JasonLautzenheiser/trizbort/pull/527.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#527>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJOXLOYFKKE3OE4DV6BIC3UJE3BZANCNFSM5G4SNUFA>
.
|
|
Sorry for the delay in looking at this. I took a quick look and found only one small issue. When something is worn by someone the code should look "has clothing".... that indicates it can be worn. However a bigger issue, and this is unrelated to your code. I've come to realized that the whole I6 export needs quite a bit of work. Since it was originally written, I've learned a lot more about I6 and I realize that there are quite a few things wrong. In fact the entire object section probably should be revamped. Like I said, this is really unrelated to y our code and just and indication of a bigger issue that needs corrected. I will most likely merge your code in soon (with a few minor changes), but will also be working on fixing the bigger issues as well. |
| } | ||
| if (thing.Worn) | ||
| { | ||
| attributes.Add("worn"); |
There was a problem hiding this comment.
this should be 'clothing' not 'worn'
2 participants
C# isn't my first or second language. Which is to say I didn't know what I was doing on many different levels (including perhaps the interpretation of all the "Thing" properties).
This might not be "production-ready" code, still I'd wanted to publish this.