Fix (this time really) the ZooModelNotFound by adding the dependency to coatjava/lib/services

[mathieuouillon]

No description provided.

[baltzell]

Since clasweb is still broken, for this PR we've at least got to confirm this test manually:

./build-coatjava.sh --unittests --spotbugs

[baltzell]

Tests pass on ifarm. On my laptop I'm getting a new error:

[ERROR] org.jlab.service.alert.AHDCTest.run -- Time elapsed: 5.995 s <<< ERROR!
ai.djl.engine.EngineException: Failed to save pytorch index file

But, since the lab's networking is messed up lately, and it ends like this below, it's probably safe to assume it's a personal problem(?):

Caused by: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.build(SunCertPathBuilder.java:148)
	at java.base/sun.security.provider.certpath.SunCertPathBuilder.engineBuild(SunCertPathBuilder.java:129)
	at java.base/java.security.cert.CertPathBuilder.build(CertPathBuilder.java:297)
	at java.base/sun.security.validator.PKIXValidator.doBuild(PKIXValidator.java:383)

Should try from offsite (from somewhere not currently blocked) ...

[baltzell]

Yes, error was due to a certificate problem on my (JLab-owned!) mac, fixed by doing https://clas12.discourse.group/t/building-coatjava-works-from-offsite-but-not-at-jlab-on-the-same-computer/551/3

[mathieuouillon]

After some discussion with Chris I no longer using a shaded jar I use maven-dependency-plugin copy-dependencies to copy all the ai.djl to lib/services

[baltzell]

Confirmed the tests pass locally.

[c-dilks]

Looks good, thanks!

Here's the new classpath; someday we may be confused what some of these JARs are (e.g., api-0.32.0.jar), but it's easy figure it out. Unfortunately it looks like the maven-dependency-plugin doesn't support renaming JARs.

 >>> tree coatjava/lib
coatjava/lib
├── clas
│   └── coat-libs-13.0.1-SNAPSHOT.jar
├── services
│   ├── api-0.32.0.jar
│   ├── clas12detector-alert-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-band-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-bg-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-cnd-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-cvt-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-dc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-eb-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-ec-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-fmt-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-ft-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-htcc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-ltcc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-mc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-mltn-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-postproc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-raster-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-recoil-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-rich-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-rtpc-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-swaps-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-tof-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-urwell-13.0.1-SNAPSHOT.jar
│   ├── clas12detector-vtx-13.0.1-SNAPSHOT.jar
│   ├── model-zoo-0.32.0.jar
│   ├── pytorch-engine-0.32.0.jar
│   ├── pytorch-jni-2.5.1-0.32.0.jar
│   ├── pytorch-model-zoo-0.32.0.jar
│   └── pytorch-native-cpu-2.5.1-linux-x86_64.jar
└── utils
    └── jclara-4.3-SNAPSHOT.jar

[baltzell]

CI job errors are evolving ...