feat: indexed table class can handle more than 4 indices #756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Plx
requested review from
baltzell,
raffaelladevita and
zieglerv
as code owners
…ttps://github.com/JeffersonLab/coatjava into 755-allow-more-than-four-indices-in-indexed-tables
* update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
N-Plx
requested review from
c-dilks,
drewkenjo,
efuchey,
ftouchte,
hauenst,
mathieuouillon,
mpaolone,
tongtongcao and
whit2333
as code owners
Merged
Member
|
Looks like squash merging #768 confused GitHub's representation of the changes this PR will do, since GitHub claims you propose to change 149 files. That's possibly a weird GitHub bug. I'm going to add a merge commit here (by clicking the update branch button) to see if that clears it up. |
Member
Yep, that fixed it. Strange GitHub bug... |
Collaborator
|
Let's get #769 merged first ... |
Member
Benchmark comparison pipelines: |
baltzell
previously approved these changes
Aug 1, 2025
…ttps://github.com/JeffersonLab/coatjava into 755-allow-more-than-four-indices-in-indexed-tables
Collaborator
|
Ran benchmarks based on #769 and compared to development: development branch
this branch
|
raffaelladevita
requested changes
Aug 5, 2025
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Show resolved
Hide resolved
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Outdated
Show resolved
Hide resolved
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Outdated
Show resolved
Hide resolved
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Outdated
Show resolved
Hide resolved
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Outdated
Show resolved
Hide resolved
raffaelladevita
requested changes
Aug 7, 2025
Collaborator
raffaelladevita
left a comment
raffaelladevita
left a comment
There was a problem hiding this comment.
Also, line 297 of IndexedList should be updated (I missed that before, sorry!)
common-tools/clas-utils/src/main/java/org/jlab/utils/groups/IndexedList.java
Outdated
Show resolved
Hide resolved
raffaelladevita
approved these changes
Aug 8, 2025
c-dilks
added a commit
that referenced
this pull request
Sep 15, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Sep 22, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 18, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Nov 21, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 5, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
tongtongcao
pushed a commit
that referenced
this pull request
Dec 31, 2025
* feat: indexed table class can handle more than 4 indices * feat: default constructor for the IndexGenerator class * restoring main class as it was * update branch (#768) * update to DC tracking to read and use the new TDC cuts ccdb table. * use live database * build: bump version number to 13.1.0 (#757) * remove unused/defunct classes * convert tabs to spaces * remove unused/defunct classes * remove long-defunct main methods * cleanup * switch example to hipo4 * remove hipo3 support * remove unused/defunct classes * cleanup, tabs/spaces, formatting, ide warnings * cleanup, formatting, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * cleanup, formatting, tabs/spaces, ide warnings * remove (newly) unused dependencies * restore object creation * convert tabs to spaces * cleanup * remove no-op * build(deps): bump org.apache.maven.plugins:maven-enforcer-plugin (#759) * apply fine timestamp correction to leadingEdgeTime * ahdc hit time corrected * add modeAHDC in PulseExtractorEngine * use wf type for hit selection * take into account simulation * replace string manipulation with bit operation * comment unnecessary code lines * use wfType 0 or 1 * fix: reduce the number of CODEOWNERS (#764) * fix: remove unused `etc/` files (#765) They are 7-8 years old, and it is not clear what they are; they are apparently unused here. --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]> * feat: can parse any byte shifts array for indexed tables * default byte shift array can only be used for less than 4 indices * misc fixes to compute long key and checks for byte shifts and index format * check bin width compatible with int * fix retrieving index from key --------- Co-authored-by: ziegler <[email protected]> Co-authored-by: Nathan Baltzell <[email protected]> Co-authored-by: raffaelladevita <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Felix Touchte Codjo <[email protected]> Co-authored-by: Christopher Dilks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can handle up to 4 indices with 16 bits or up to 9 indices with 7 bits. Could be made more generic.