Skip to content

Conversation

@N-Plx
Copy link
Collaborator

@N-Plx N-Plx commented Sep 8, 2025

No description provided.

@N-Plx N-Plx linked an issue Sep 8, 2025 that may be closed by this pull request
@N-Plx
Copy link
Collaborator Author

N-Plx commented Sep 10, 2025

@ftouchte Hi Felix, I'm adding calibration constant reading to the atof engine. We are loading the tables for the atof and ahdc together from the way you defined the CalibrationConstantLoader, which is completely fine, but then maybe we should move this loading to the ALERTEngine so we don't do it in both the ATOF and AHDC engines. Does that sound right for you? Do you want to make the changes or do you want me to make them? If you make them, please refer to this line to set the proper number of indices for the ATOF tables

Map<String, Integer> tableMap = new HashMap<>();

@N-Plx N-Plx marked this pull request as ready for review September 10, 2025 18:10
@ftouchte
Copy link
Collaborator

ftouchte commented Sep 10, 2025

Hello Noémie, it is a good idea. The code is not fresh in my mind, so I think you will be more efficient than me.

  • I used to run the reconstruction with the AHDCEngine only. If we move it to the ALERTEngine, that means that I will have to use both of them in this order: ALERTEngine then AHDCEngine. Am I right? Is there a way to directly refer to the ALERTEngine inside the AHDCEngine?

I just have a small modification to propose. Here , I used this package name: package org.jlab.rec.constants;. I just notice that it was not very safe. I propose : package org.jlab.rec.alert.constants;. (This can be done later.)

@N-Plx N-Plx merged commit 666c825 into development Sep 11, 2025
35 checks passed
c-dilks pushed a commit that referenced this pull request Sep 15, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
tongtongcao pushed a commit that referenced this pull request Sep 22, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
tongtongcao pushed a commit that referenced this pull request Nov 18, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
tongtongcao pushed a commit that referenced this pull request Nov 21, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
tongtongcao pushed a commit that referenced this pull request Dec 5, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
@baltzell baltzell added the rg-l label Dec 23, 2025
tongtongcao pushed a commit that referenced this pull request Dec 31, 2025
* feat: added start time reading

* feat: reading calib constants for the atof

* feat: adding time offset to hit times

* fix: order for reference bar time is set to 0

* fix: bar to bar time offset needs to be halved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ALERT ATOF bar calibrations

4 participants