-
Notifications
You must be signed in to change notification settings - Fork 28
feat: added start time reading #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ftouchte Hi Felix, I'm adding calibration constant reading to the atof engine. We are loading the tables for the atof and ahdc together from the way you defined the CalibrationConstantLoader, which is completely fine, but then maybe we should move this loading to the ALERTEngine so we don't do it in both the ATOF and AHDC engines. Does that sound right for you? Do you want to make the changes or do you want me to make them? If you make them, please refer to this line to set the proper number of indices for the ATOF tables coatjava/reconstruction/alert/src/main/java/org/jlab/service/atof/ATOFEngine.java Line 141 in cd6cb41
|
|
Hello Noémie, it is a good idea. The code is not fresh in my mind, so I think you will be more efficient than me.
I just have a small modification to propose. Here , I used this package name: |
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
* feat: added start time reading * feat: reading calib constants for the atof * feat: adding time offset to hit times * fix: order for reference bar time is set to 0 * fix: bar to bar time offset needs to be halved
No description provided.