feat: QADB binning support #827
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: test wrapper feat: write charge comparison table feat: initial correction implementation fix: need protected default constructor for inheritance refactor: separate `readSequence` event loop to a protected method so that a derived class can use it fix: cleanup, since downsampling moved downstream feat: store event number feat: QADB binning classes feat: some example code feat: general `coatjava` script fix: start convincing this stuff to work fix: fencepost error, and missing event number feat: handle charge feat: get charge extrema feat: support RG-D charge override feat: sugar refactor: organize methods fix: spelling fix: +1 fix: if on boundary take earlier bin to be consistent with the current QADB convention fix: remove bin/coatjava fix: cleanup diff doc: cleanup feat: validate scaler ordering fix: docstrings refactor: DeMorgan law build(deps): bump com.github.spotbugs:spotbugs-maven-plugin Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.9.3.2 to 4.9.4.2. - [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases) - [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.9.3.2...spotbugs-maven-plugin-4.9.4.2) --- updated-dependencies: - dependency-name: com.github.spotbugs:spotbugs-maven-plugin dependency-version: 4.9.4.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> remove unused variable add rollover fix (example) prepare to test, find a rollover nothing nothing add comment use CLAS12DIR debug better printout add toString really fix clock rollover relax cleanup add fix clock rollover option bugfix feat: instantiation without `data` creation backmerge 'origin/development' refactor: common maven goal wrappers (#820) refactor: cleanup backmerge 'origin/development'
baltzell
requested review from
c-dilks
and removed request for
raffaelladevita and
zieglerv
Member
|
No need, squash merging will do this, and the PR will retain the messy commit history, if ever needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #770, but squashing the last 31 commits like this to get a commit message like github would've done (?) and then fixing rebase conflicts.