Skip to content

upated knockout condition in ECAL to cover all used status values #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baltzell merged 2 commits into from
Oct 6, 2025
Merged

upated knockout condition in ECAL to cover all used status values #856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea546f2
upated knockout condition in ECAL to cover all used status values
raffaelladevita Oct 3, 2025
2912f56
Merge branch 'development' into iss855-ecalStatuses
raffaelladevita Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions reconstruction/ec/src/main/java/org/jlab/service/ec/ECCommon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,12 @@ public static List<ECStrip> readStripsHipo(DataEvent event, int run, ConstantsM
int ip = bank.getShort("component",i);
int tdc = bank.getInt("TDC",i);

if(status.getIntValue("status",is,il,ip)==2) continue; //for MC use only
int istatus = status.getIntValue("status",is,il,ip);

if(istatus==2 || istatus==3) continue;

if(tdc>0) {
if(!tdcs.hasItem(is,il,ip)) tdcs.add(new ArrayList<Integer>(),is,il,ip);
if(!tdcs.hasItem(is,il,ip)) tdcs.add(new ArrayList<>(),is,il,ip);
tdcs.getItem(is,il,ip).add(tdc);
}
}
Expand All @@ -366,11 +368,13 @@ public static List<ECStrip> readStripsHipo(DataEvent event, int run, ConstantsM
float t = bank.getFloat("time", i) + (float) tmf.getDoubleValue("offset",is,il,ip) // TDC-FADC offset (sector, layer, PMT)
+ (float) fo.getDoubleValue("offset",is,il,0); // TDC-FADC offset (sector, layer)

if (status.getIntValue("status",is,il,ip)==3) continue; //for MC use only
int istatus = status.getIntValue("status",is,il,ip);

if(istatus==1 || istatus==3) continue;

ECStrip strip = new ECStrip(is, il, ip);

strip.setStatus(status.getIntValue("status",is,il,ip));
strip.setStatus(istatus);
strip.setADC(adc);
strip.setTriggerPhase(triggerPhase);
strip.setID(bank.trueIndex(i)+1);
Expand Down