Skip to content

feat: use index-based accessors for waveforms #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
c-dilks merged 2 commits into from
Oct 16, 2025
Merged

feat: use index-based accessors for waveforms #883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d287521
use index-based accessors for waveform
baltzell Oct 13, 2025
e628a14
Merge branch 'development' into bank-access
raffaelladevita Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/HipoExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ protected List<Pulse> getPulses(int n, IndexedTable it, DataBank wfBank) {
short[] samples = new short[n];
for (int i=0; i<wfBank.rows(); ++i) {
for (int j=0; j<n; ++j)
samples[j] = wfBank.getShort(String.format("s%d",j+1), i);
samples[j] = wfBank.getShort(j+5, i);
long timestamp = wfBank.getLong("timestamp",i);
int time = wfBank.getInt("time",i);
List<Pulse> p = it==null ? extract(null, i, timestamp, time, samples) :
Expand All @@ -146,7 +146,7 @@ protected List<Pulse> getPulses(int n, IndexedTable it, Bank wfBank) {
short[] samples = new short[n];
for (int i=0; i<wfBank.getRows(); ++i) {
for (int j=0; j<n; ++j)
samples[j] = wfBank.getShort(String.format("s%d",j+1), i);
samples[j] = wfBank.getShort(j+5, i);
// FIXME: Can speed this up (but looks like not for DataBank?):
//samples[j] = wfBank.getShort(String.format(5+j,j+1), i);
int time = wfBank.getInt("time",i);
Expand Down