Fix Coveralls submission, and re-enable Coveralls submission from CI#315
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 90.25% 90.76% +0.51%
==========================================
Files 2 2
Lines 195 195
==========================================
+ Hits 176 177 +1
+ Misses 19 18 -1
Continue to review full report at Codecov.
|
DilumAluthge
changed the title
DilumAluthge
force-pushed
the
dpa/fix-coveralls
branch
from
906c54a to
c9eb6fa
Compare
vtjnash
reviewed
Jun 9, 2021
DilumAluthge
force-pushed
the
dpa/fix-coveralls
branch
from
ef9f02a to
b476fe9
Compare
vtjnash
reviewed
Jun 9, 2021
vtjnash
approved these changes
Jun 9, 2021
vtjnash
left a comment
vtjnash
left a comment
Member
There was a problem hiding this comment.
Thanks for tracking that down!
vtjnash
reviewed
Jun 9, 2021
Member
Author
|
Your tip to look at lemurheavy/coveralls-public#1527 was spot-on. The issue was indeed that our JSON was not typed the way that Coveralls expected it to be typed. |
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
DilumAluthge
force-pushed
the
dpa/fix-coveralls
branch
from
fe023c7 to
d108113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314
Closes #310
Closes #313