fix infinite loops for custom folder and buildfolder#175
Merged
Conversation
Contributor
Author
|
@tlienart do you have time to review this PR by any chance? |
tlienart
approved these changes
Apr 9, 2024
Collaborator
|
yeah really struggling with my maintainers duty over the last 6mo :/ |
Contributor
Author
|
No worries :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the changes in #169 I found that this line should probably use the parameters instead of the default
"docs"and"build"values.Though I am not sure why the above mentioned PR changed the behaviour.
This closes #174.