Skip to content

Addressing issues of PR 1153#1163

Merged
ameligrana merged 15 commits into
JuliaDynamics:mainfrom
bergio13:fix-pull-1153
Jun 7, 2025
Merged

Addressing issues of PR 1153#1163
ameligrana merged 15 commits into
JuliaDynamics:mainfrom
bergio13:fix-pull-1153

Conversation

@bergio13
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.41%. Comparing base (8b5b456) to head (139d17f).
Report is 188 commits behind head on main.

Files with missing lines Patch % Lines
src/core/model_standard.jl 68.42% 6 Missing ⚠️
src/core/model_accessing_API.jl 93.33% 1 Missing ⚠️
src/core/model_free_extensions.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1163       +/-   ##
===========================================
+ Coverage   70.12%   85.41%   +15.28%     
===========================================
  Files          42       38        -4     
  Lines        2718     2619       -99     
===========================================
+ Hits         1906     2237      +331     
+ Misses        812      382      -430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ameligrana ameligrana marked this pull request as ready for review June 2, 2025 15:27
Comment thread src/core/model_free_extensions.jl Outdated
Comment thread docs/src/devdocs.md Outdated
Comment thread src/core/model_accessing_API.jl Outdated
bergio13 and others added 3 commits June 3, 2025 10:40
Co-authored-by: Adriano Meligrana <68152031+Tortar@users.noreply.github.com>
Comment thread src/core/agent_containers.jl
Comment thread src/core/agent_containers.jl
Copy link
Copy Markdown
Member

@ameligrana ameligrana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bergio13, nice work, the changes seem fine to me

@ameligrana ameligrana merged commit d970488 into JuliaDynamics:main Jun 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants