Allow specifying current folder and suggesting filenames in file dialogs#501
Open
halleysfifthinc wants to merge 2 commits intoJuliaGraphics:masterfrom
Open
Allow specifying current folder and suggesting filenames in file dialogs#501halleysfifthinc wants to merge 2 commits intoJuliaGraphics:masterfrom
halleysfifthinc wants to merge 2 commits intoJuliaGraphics:masterfrom
Conversation
- `open_dialog` only supports `current_folder` - `save_dialog` supports both new kwargs Refs: https://developer.gnome.org/gtk3/stable/GtkFileChooser.html#gtk-file-chooser-set-current-name https://developer.gnome.org/gtk3/stable/GtkFileChooser.html#gtk-file-chooser-set-current-folder https://developer.gnome.org/gtk3/stable/GtkFileChooserDialog.html#gtkfilechooserdialog-setting-up
Collaborator
|
Great, could you still add a test, where at least the code is run? In that way at least we can guarantee that the code is runnable. |
|
This seems useful, I was just looking for how to set this. Any chance it can be merged? |
Author
|
👍 I'll try to get back to this sometime this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
open_dialogonly supportscurrent_foldercurrent_nameif that seems like a more thorough support of these features.save_dialogsupports both new kwargsGtk documentation recommends against setting the current folder due to some heuristics in
GtkFileChooserwhich are supposed to set sensible/helpful folders, in my experience the dialogs only ever opened to the "Recent" folder.I tested that all of the combinations of function & kwargs works properly; it doesn't seem like there is any other way to test these features via code?
I also added examples to the documentation.
Fixes #500.
Refs:
https://developer.gnome.org/gtk3/stable/GtkFileChooser.html#gtk-file-chooser-set-current-name
https://developer.gnome.org/gtk3/stable/GtkFileChooser.html#gtk-file-chooser-set-current-folder