Merged
Conversation
The advantage is that the whole depot will be cached instead of just the artifacts. Also deleted the build step since Distributed doesn't have a build.jl file.
giordano
reviewed
Dec 12, 2024
Member
giordano
left a comment
giordano
left a comment
There was a problem hiding this comment.
Running CI on nightly means that precompile cache will be invalidated somewhat frequently, but moving to julia-actions/cache is a good idea regardless.
Member
Author
|
Speaking of which, should we be running CI on 1.11+ now that it's upgradeable? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 79.33% 79.33%
=======================================
Files 10 10
Lines 1916 1916
=======================================
Hits 1520 1520
Misses 396 396 ☔ View full report in Codecov by Sentry. |
ViralBShah
approved these changes
Dec 12, 2024
3 tasks
63 tasks
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advantage is that the whole depot will be cached instead of just the artifacts. Also deleted the build step since Distributed doesn't have a build.jl file.