Ensure correct type parameter of serialized RemoteChannel#179
Merged
DilumAluthge merged 1 commit intomasterfrom Feb 18, 2026
Merged
Ensure correct type parameter of serialized RemoteChannel#179DilumAluthge merged 1 commit intomasterfrom
DilumAluthge merged 1 commit intomasterfrom
Conversation
When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel.
andreasnoack
force-pushed
the
an/remotechannelserialize
branch
from
303e2fe to
594f289
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 79.34% 79.34%
=======================================
Files 10 10
Lines 1951 1951
=======================================
Hits 1548 1548
Misses 403 403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I'll take a closer look tomorrow. The source code change looks okay.
|
Member
Author
|
Serialize works recursively so it will still call |
Member
|
Ah, okay, in that case the changes to the tests sound fine. I'll take one last look later today, and then I'll approve and merge. |
Member
|
@JamesWrigley Are you good with me merging this? |
Member
|
This will land on Julia master in JuliaLang/julia#61073 |
DilumAluthge
pushed a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
This is a forward-port of JuliaLang/Distributed.jl#179 (JuliaLang/Distributed.jl@6649a94). When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel. (cherry picked from commit 6649a94075ff6a52ee9558db3ec4491496bf1bea)
63 tasks
DilumAluthge
pushed a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
This is a forward-port of JuliaLang/Distributed.jl#179 (JuliaLang/Distributed.jl@6649a94). When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel. (cherry picked from commit 6649a94075ff6a52ee9558db3ec4491496bf1bea)
DilumAluthge
pushed a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
This is a forward-port of JuliaLang/Distributed.jl#179 (JuliaLang/Distributed.jl@6649a94). When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel. (cherry picked from commit 6649a94075ff6a52ee9558db3ec4491496bf1bea) (cherry picked from commit 2e52996)
DilumAluthge
pushed a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 24, 2026
This is a forward-port of JuliaLang/Distributed.jl#179 (JuliaLang/Distributed.jl@6649a94). When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel. (cherry picked from commit 6649a94075ff6a52ee9558db3ec4491496bf1bea) (cherry picked from commit 2e52996)
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When serializing RemoteChannels, a new zeroed RemoteChannel is constructed. However, the input type parameter might be part of an outer type parameter which can then lead to a TypeError during deserialization. The fix is just to reuse the type parameter of the input when constructing the zeroed RemoteChannel.
Fixes #178