Rename one method of run_work_thunk() to run_work_thunk_remotevalue(); this fixes a JET error around matching methods for run_work_thunk(...)#181
Merged
DilumAluthge merged 1 commit intomasterfrom Feb 21, 2026
Conversation
…e()`; this fixes a JET error around matching methods for `run_work_thunk(...)` This fixes the following JET error: ``` │┌ run_work_thunk(rv::Distributed.RemoteValue, thunk::Bool) @ Distributed /workpath/Distributed.jl/src/process_messages.jl:79 ││ no matching method found `run_work_thunk(::Bool, ::Bool)`: Distributed.run_work_thunk(thunk::Bool, false) │└──────────────────── ```
DilumAluthge
changed the title
run_work_thunk() to `run_work_thunk_remotevalu…run_work_thunk() to run_work_thunk_remotevalue(); this fixes a JET error around matching methods for run_work_thunk(...)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 10 10
Lines 1957 1957
=======================================
Hits 1555 1555
Misses 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DilumAluthge
added a commit
to JuliaParallel/DistributedNext.jl
that referenced
this pull request
Feb 22, 2026
…e()`; this fixes a JET error around matching methods for `run_work_thunk(...)` (#181) This is a forward-port of JuliaLang/Distributed.jl#181 (JuliaLang/Distributed.jl@2adcd26). This fixes the following JET error: ``` │┌ run_work_thunk(rv::Distributed.RemoteValue, thunk::Bool) @ Distributed /workpath/Distributed.jl/src/process_messages.jl:79 ││ no matching method found `run_work_thunk(::Bool, ::Bool)`: Distributed.run_work_thunk(thunk::Bool, false) │└──────────────────── ``` (cherry picked from commit 2adcd26e81cec03dbf81fa94071b4c4499e539a1)
This was referenced Feb 22, 2026
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following JET error:
This is an alternative to #168 (closes #168).
I like this better, because it makes the code a bit easier to read by making it more clear which method you're actually calling.
I searched the Julia manual and found no results for
run_work_thunk, so I think this is not public API, and thus I think we're allowed to change it.