Fix julia#55850 by using safe_realpath instead of abspath in projname

[christiangnrd]

Replaces REPLExt.projname with REPL.projname since they are identical.

Will solve JuliaLang/julia#55850 for situations where Pkg is loaded once JuliaLang/julia#55851 is merged.

Test will be covered by JuliaLang/julia#55851.

[christiangnrd]

@IanButterworth This is also ready for review.

[IanButterworth]

Just to highlight because the diff isn't clear in either PR, the difference between the two projnames is that Pkg uses
Types.read_project to get the project name, where REPL's directly uses Base.TOML.Parser.

I don't see an issue switching over because there's no side effects/caching of the project in either.

Pkg's

function projname(project_file::String)
    project = try
        Types.read_project(project_file)
    catch
        nothing
    end
    if project === nothing || project.name === nothing
        name = basename(dirname(project_file))
    else
        name = project.name::String
    end
    for depot in Base.DEPOT_PATH
        envdir = joinpath(depot, "environments")
        if startswith(abspath(project_file), abspath(envdir))
            return "@" * name
        end
    end
    return name
end

REPL's

function projname(project_file::String)
    if isfile(project_file)
        name = try
            # The `nothing` here means that this TOML parser does not return proper Dates.jl
            # objects - but that's OK since we're just checking the name here.
            p = Base.TOML.Parser{nothing}()
            Base.TOML.reinit!(p, read(project_file, String); filepath=project_file)
            proj = Base.TOML.parse(p)
            get(proj, "name", nothing)
        catch
            nothing
        end
    else
        name = nothing
    end
    if name === nothing
        name = basename(dirname(project_file))
    end
    for depot in Base.DEPOT_PATH
        envdir = joinpath(depot, "environments")
        if startswith(abspath(project_file), abspath(envdir))
            return "@" * name
        end
    end
    return name
end

[KristofferC]

In my opinion I rather have some code duplication than start reaching into the internals of things. But that's just my opinion.

[IanButterworth]

Ok, let's just implement the JuliaLang/julia#55851 fix in both then.

Sorry @christiangnrd for the flip flop

[christiangnrd]

This seems good to go on all platforms now.