Load ScopedValues symbols from their source#80
Merged
Conversation
Loading `@with` from Base is accessing internals because `@with` is not a public symbol in Base.
tecosaur
force-pushed
the
LilithHafner-patch-1
branch
from
6184d71 to
9802b6c
Compare
Member
|
You forgot a comma 🙂. Is this good to merge before the PR you linked is resolved? |
Member
Author
|
Yes. This is good to merge before that. Indeed, I don't think the linked PR should merge because I want folks to use |
Member
Author
|
@tecosaur, is this good with you to merge? |
Member
|
Yup, it's just been waiting for me to be sitting down at the right computer with a little spare time 🙂 |
oscardssmith
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Aug 15, 2024
Stop loading `ScopedValues` with `using` so folks use `ScopedValues.with` or `using ScopedValues` rather than `Base.with`. Implements #55095 (comment) ~Have to bump the StyledStrings stdlib to include JuliaLang/StyledStrings.jl#80 Done --------- Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
Stop loading `ScopedValues` with `using` so folks use `ScopedValues.with` or `using ScopedValues` rather than `Base.with`. Implements JuliaLang#55095 (comment) ~Have to bump the StyledStrings stdlib to include JuliaLang/StyledStrings.jl#80 Done --------- Co-authored-by: Dilum Aluthge <dilum@aluthge.com>
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Aug 19, 2024
Stop loading `ScopedValues` with `using` so folks use `ScopedValues.with` or `using ScopedValues` rather than `Base.with`. Implements #55095 (comment) ~Have to bump the StyledStrings stdlib to include JuliaLang/StyledStrings.jl#80 Done --------- Co-authored-by: Dilum Aluthge <dilum@aluthge.com> (cherry picked from commit e1aefeb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading
@withfrom Base is accessing internals because@withis not a public symbol in Base.See also: JuliaLang/julia#55095 (comment)