Bounds error in runtime in `fixup_node` when testing Quaternions.jl on 1.13

[KristofferC]

https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/5abf758_vs_01a2ead/Quaternions.primary.log

Internal error: during type inference of
iterate(Base.Iterators.Flatten{Base.Generator{Tuple{typeof(DataType), typeof(DataType)}, Main.var"#28#29"{Tuple{typeof(DataType), typeof(DataType)}}}})
Encountered unexpected error in runtime:
BoundsError(a=Array{Int64, 1}(dims=(131,), mem=Memory{Int64}(209, 0x776f35dad550)[2, 1, 0, 1, 1, 0, 0, 1, 4, 0, 0, 1, 0, 1, 2, 1, 0, 1, 1, 0, 0, 1, 3, 0, 1, 0, 1, 1, 0, 0, 1, 1, 0, 1, 0, 0, 0, 1, 2, 1, 0, 1, 1, 0, 0, 1, 4, 0, 1, 0, 2, 1, 0, 1, 1, 0, 0, 2, 1, 1, 1, 0, 0, 2, 1, 0, 1, 1, 0, 0, 2, 1, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 1, 1, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]), i=(205,))
throw_boundserror at ./essentials.jl:13
checkbounds at ./essentials.jl:385 [inlined]
getindex at ./essentials.jl:964 [inlined]
fixup_node at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2034
fixup_phinode_values! at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2002 [inlined]
fixup_node at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2011
just_fixup! at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2067
just_fixup! at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2057 [inlined]
non_dce_finish! at ./../usr/share/julia/Compiler/src/ssair/ir.jl:2107
adce_pass! at ./../usr/share/julia/Compiler/src/ssair/passes.jl:2150
run_passes_ipo_safe at ./../usr/share/julia/Compiler/src/optimize.jl:1049
run_passes_ipo_safe at ./../usr/share/julia/Compiler/src/optimize.jl:1062 [inlined]
optimize at ./../usr/share/julia/Compiler/src/optimize.jl:1035
jfptr_optimize_88336.1 at /opt/julia/lib/julia/sys.so (unknown line)
_jl_invoke at /source/src/gf.c:4116 [inlined]
ijl_apply_generic at /source/src/gf.c:4313
finish_nocycle at ./../usr/share/julia/Compiler/src/typeinfer.jl:231
jfptr_finish_nocycle_87864.1 at /opt/julia/lib/julia/sys.so (unknown line)
_jl_invoke at /source/src/gf.c:4116 [inlined]
ijl_apply_generic at /source/src/gf.c:4313
typeinf at ./../usr/share/julia/Compiler/src/abstractinterpretation.jl:4493
typeinf_ext at ./../usr/share/julia/Compiler/src/typeinfer.jl:1386
typeinf_ext_toplevel at ./../usr/share/julia/Compiler/src/typeinfer.jl:1575 [inlined]
typeinf_ext_toplevel at ./../usr/share/julia/Compiler/src/typeinfer.jl:1584
jfptr_typeinf_ext_toplevel_87172.1 at /opt/julia/lib/julia/sys.so (unknown line)

[KristofferC]

MWE:

let
    Ts = (Float64, Float32)
    Ttrips = [(Ta, Tb, Tc) for Ta in Ts for Tb in Ts for Tc in Ts]
end

But seems fixed on nightly?

[adienes]

bisect says fixed by #59413

[vtjnash]

Seems probably unrelated to that bug, just breaking the MWE

[KristofferC]

This particular error got introduced in d82ccc1 (@adienes) but that obviously just surfaced the existing bug.

[adienes]

I wonder if this bug has the same cause as #57827 then? since d82ccc1 actually fixed the second reproducer there

[aviatesk]

Fixed by #60697 .