Skip to content

added missing matrix exponentiation methods #29782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefanKarpinski merged 6 commits into from
Oct 30, 2018
Merged

added missing matrix exponentiation methods #29782

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
61d6384
added missing matrix exponentiation methods
ExpandingMan Oct 23, 2018
9881db3
added some tests
ExpandingMan Oct 23, 2018
0c483a8
moved new methods to LinearAlgebra
ExpandingMan Oct 23, 2018
72266ad
added general method and cleaned up tests
ExpandingMan Oct 24, 2018
9def8c7
moved methods
ExpandingMan Oct 24, 2018
6b9f486
eliminate spurious allocation
ExpandingMan Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions stdlib/LinearAlgebra/src/LinearAlgebra.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,9 @@ rdiv!(A, B)
copy_oftype(A::AbstractArray{T}, ::Type{T}) where {T} = copy(A)
copy_oftype(A::AbstractArray{T,N}, ::Type{S}) where {T,N,S} = convert(AbstractArray{S,N}, A)

# matrix exponentials for ℯ
Base.:^(::Irrational{:ℯ}, A::AbstractMatrix) = exp(A)

@fredrikekre fredrikekre Oct 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move this just below

julia/stdlib/LinearAlgebra/src/dense.jl

Line 490 in 84024a1

exp(A::StridedMatrix{<:Union{Integer,Complex{<:Integer}}}) = exp!(float.(A))

@ExpandingMan ExpandingMan Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about that? the reason I didn't put it in there is because it is only for dense, it could work for sparse array types as well.

@fredrikekre fredrikekre Oct 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it doesn't, this is the generic exp so I would put it here.


include("adjtrans.jl")
include("transpose.jl")

Expand Down
4 changes: 4 additions & 0 deletions stdlib/LinearAlgebra/test/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,10 @@ end
[4.000000000000000 -1.414213562373094 -1.414213562373095
-1.414213562373095 4.999999999999996 -0.000000000000000
0 -0.000000000000002 3.000000000000000])

# alias using ℯ, should be exact
@test ℯ^(fill(2, (4,4))) == exp(fill(2, (4,4)))

@fredrikekre fredrikekre Oct 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also move these test out the loop over the elty, maybe to a separate sub-testset.

@test ℯ^(fill(2.4, (4,4))) == exp(fill(2.4, (4,4)))
end

@testset "Additional tests for $elty" for elty in (Float64, Complex{Float64})
Expand Down