Skip to content

file tests: in the "tempname with parent" test, temporarily unset the TMPDIR environment variable while running the test#43012

Merged
DilumAluthge merged 1 commit into
masterfrom
dpa/test-tempname-with-parent-tmpdir-env
Nov 9, 2021
Merged

file tests: in the "tempname with parent" test, temporarily unset the TMPDIR environment variable while running the test#43012
DilumAluthge merged 1 commit into
masterfrom
dpa/test-tempname-with-parent-tmpdir-env

Conversation

@DilumAluthge

@DilumAluthge DilumAluthge commented Nov 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

See also: #42995
See also: #43011

This pull request is needed for #42995.

@DilumAluthge DilumAluthge added test This change adds or pertains to unit tests filesystem Underlying file system and functions that use it ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 9, 2021
@fredrikekre

fredrikekre commented Nov 9, 2021

Copy link
Copy Markdown
Member

Seems like these tests work with TMPDIR set?

@DilumAluthge

DilumAluthge commented Nov 9, 2021

Copy link
Copy Markdown
Member Author

Seems like these tests work with TMPDIR set?

Not on Linux.

@fredrikekre

fredrikekre commented Nov 9, 2021

Copy link
Copy Markdown
Member

I meant that they should work and that it is a bug.

@DilumAluthge

DilumAluthge commented Nov 9, 2021

Copy link
Copy Markdown
Member Author

Yeah, it's a bug: #35785

If and when someone is able to pick up #38879 and finish it, then we can revert this PR. But for now, we need this PR so that we can set the TMPDIR environment variable on CI.

@DilumAluthge
file tests: in the "tempname with parent" test, temporarily unset…
c24eeb6 
… the `TMPDIR` environment variable while running the test
@DilumAluthge DilumAluthge force-pushed the dpa/test-tempname-with-parent-tmpdir-env branch from 33c72ca to c24eeb6 Compare November 9, 2021 19:47
@DilumAluthge

DilumAluthge commented Nov 9, 2021

Copy link
Copy Markdown
Member Author

@staticfloat Can you review this?

@DilumAluthge DilumAluthge merged commit ac2ee4d into master Nov 9, 2021
@DilumAluthge DilumAluthge deleted the dpa/test-tempname-with-parent-tmpdir-env branch November 9, 2021 23:08
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
@DilumAluthge @KristofferC
file tests: in the "tempname with parent" test, temporarily unset…
40dca0f 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
@KristofferC KristofferC mentioned this pull request Nov 10, 2021
Merged
66 tasks
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
@DilumAluthge @KristofferC
file tests: in the "tempname with parent" test, temporarily unset…
ba78fb2 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
@KristofferC KristofferC mentioned this pull request Nov 10, 2021
Merged
95 tasks
KristofferC pushed a commit that referenced this pull request Nov 10, 2021
@DilumAluthge @KristofferC
file tests: in the "tempname with parent" test, temporarily unset…
a873f7d 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
@DilumAluthge @KristofferC
file tests: in the "tempname with parent" test, temporarily unset…
3adfd6a 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
@DilumAluthge @KristofferC
file tests: in the "tempname with parent" test, temporarily unset…
bc3e188 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
daviehh pushed a commit to daviehh/julia that referenced this pull request Nov 16, 2021
@DilumAluthge @daviehh
file tests: in the "tempname with parent" test, temporarily unset…
af4708d 
… the `TMPDIR` environment variable while running the test (JuliaLang#43012)

(cherry picked from commit ac2ee4d)
mkg20001 pushed a commit to mkg20001/nixpkgs that referenced this pull request Nov 29, 2021
@mkg20001
julia_16-bin: 1.6.3 -> 1.6.4
ed25420 
Patches: JuliaLang/julia@v1.6.3...v1.6.4

Broken `tempname` tests disabled upstream, dropping workaround patch:

    JuliaLang/julia#43012

The issue itself however, persists:

    JuliaLang/julia#35785
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@DilumAluthge @LilithHafner
file tests: in the "tempname with parent" test, temporarily unset…
f7c98e7 
… the `TMPDIR` environment variable while running the test (JuliaLang#43012)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@DilumAluthge @LilithHafner
file tests: in the "tempname with parent" test, temporarily unset…
32f4c2e 
… the `TMPDIR` environment variable while running the test (JuliaLang#43012)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@DilumAluthge @staticfloat
file tests: in the "tempname with parent" test, temporarily unset…
dcace55 
… the `TMPDIR` environment variable while running the test (#43012)

(cherry picked from commit ac2ee4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees

No one assigned

Labels

ci Continuous integration filesystem Underlying file system and functions that use it test This change adds or pertains to unit tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DilumAluthge @fredrikekre @staticfloat @KristofferC