fix #45825, BitArray methods assuming 1-indexing of AbstractArray#45835
Merged
JeffBezanson merged 1 commit intomasterfrom Jul 18, 2022
Merged
fix #45825, BitArray methods assuming 1-indexing of AbstractArray#45835JeffBezanson merged 1 commit intomasterfrom
JeffBezanson merged 1 commit intomasterfrom
Conversation
JeffBezanson
added
arrays
vchuravy
added
backport 1.6
N5N3
reviewed
Jun 28, 2022
Member
|
Might be too breaking before 2.0, but shouldn't |
Member
Author
|
Oh I see, I was just wrong about what behavior is intended then. I was thinking of the argument as an iterator. |
JeffBezanson
force-pushed
the
jb/fix45825
branch
from
636b9be to
4d22bb2
Compare
Member
Author
|
Ok this should be right now. Using |
JeffBezanson
force-pushed
the
jb/fix45825
branch
from
4d22bb2 to
8a4eb38
Compare
N5N3
reviewed
Jun 30, 2022
JeffBezanson
force-pushed
the
jb/fix45825
branch
from
8a4eb38 to
8c780d6
Compare
This was referenced Jul 5, 2022
JeffBezanson
force-pushed
the
jb/fix45825
branch
from
8c780d6 to
5d9c324
Compare
32 tasks
KristofferC
pushed a commit
that referenced
this pull request
Jul 20, 2022
78 tasks
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #45825