Skip to content

Redo of "Add ability to add output prefixes to the REPL output and use that to implement an IPython mode"#46781

Merged
KristofferC merged 2 commits intomasterfrom
kc/output_prompts
Sep 19, 2022
Merged

Redo of "Add ability to add output prefixes to the REPL output and use that to implement an IPython mode"#46781
KristofferC merged 2 commits intomasterfrom
kc/output_prompts

Conversation

@KristofferC
Copy link
Copy Markdown
Member

Original PR (#46474) had to be reverted due to a change in a signature that happened after CI ran on that PR.

@KristofferC KristofferC added the REPL Julia's REPL (Read Eval Print Loop) label Sep 15, 2022
@KristofferC KristofferC force-pushed the kc/output_prompts branch 2 times, most recently from 6238a64 to 07a2728 Compare September 16, 2022 09:49
@PallHaraldsson
Copy link
Copy Markdown
Contributor

Is it confusing (for the future) to call it an "IPython mode"?

Should it be "Jupyter mode" and module? That's what used in Julia, and IPython implementation detail, or is it even still used (or will forever)? If Jupyter is a better term, then change before 1.9 get released...

@KristofferC
Copy link
Copy Markdown
Member Author

Should it be "Jupyter mode"

Why would it be called that?

@PallHaraldsson
Copy link
Copy Markdown
Contributor

I'm not sure, I know about IPython and the history sort of. I thought Jupyter replaced IPython practically, for notebook users that would be what they know.

If this is only about numbered mode then maybe call it "Pluto mode" or just "numbered mode"?

@StefanKarpinski
Copy link
Copy Markdown
Member

IPython still exists but is now a Python-specific REPL. This makes the Julia REPL a bit more like IPython.

@KristofferC
Copy link
Copy Markdown
Member Author

I thought Jupyter replaced IPython practically,

https://github.com/ipython/ipython

If this is only about numbered mode then maybe call it "Pluto mode" or just "numbered mode"?

It is not, it is about being like IPython, hence "IPython mode" :).

@hyrodium
Copy link
Copy Markdown
Contributor

@PallHaraldsson
I overlooked that there was already a discussion about the naming of this feature. I still think it's better to rename this feature, and opened a PR (#49314). Please comment in the PR if you have any thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

REPL Julia's REPL (Read Eval Print Loop)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants