Skip to content

bugfix: fld1 order of ops#46938

Merged
oscardssmith merged 5 commits intoJuliaLang:masterfrom
JeffreySarnoff:jas/fld1fix
Oct 3, 2022
Merged

bugfix: fld1 order of ops#46938
oscardssmith merged 5 commits intoJuliaLang:masterfrom
JeffreySarnoff:jas/fld1fix

Conversation

@JeffreySarnoff
Copy link
Copy Markdown
Contributor

@JeffreySarnoff JeffreySarnoff commented Sep 28, 2022

fixes #28973
see explaination

@JeffreySarnoff
Copy link
Copy Markdown
Contributor Author

JeffreySarnoff commented Sep 29, 2022

@admin I do not understand the error. It does not seem to have anything to do with the PR. Help, please.

@oscardssmith
Copy link
Copy Markdown
Member

oscardssmith commented Sep 29, 2022

I just rebased, which which hopefully helps.

@JeffreySarnoff
Copy link
Copy Markdown
Contributor Author

JeffreySarnoff commented Sep 29, 2022

not ok yet
failed on make release

Executing precompile statements... 1438/1935*** This error is usually fixed by running `make clean`. If the error persists, try `make cleanall`. ***
gmake[1]: Leaving directory '/usr/home/julia/buildbot/w1_builder/package_freebsd64/build'
Killed
gmake[1]: *** [sysimage.mk:89: /usr/home/julia/buildbot/w1_builder/package_freebsd64/build/usr/lib/julia/sys-o.a] Error 1
gmake: *** [Makefile:90: julia-sysimg-release] Error 2
program finished with exit code 2

@JeffreySarnoff
Copy link
Copy Markdown
Contributor Author

JeffreySarnoff commented Sep 30, 2022 •
edited
Loading

@admin I resolved the one error in my changes (extra whitespace). Now the failure is:
SparseArrays/sparsematrix_constructors_indexing (7) | failed at 2022-09-29T21:51:30.629
UNHANDLED TASK ERROR: EOFError: read end of file
I did nothing with SparseArrays. I do not see anything I can do about this. What do you advise?

@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.8 Change should be backported to release-1.8 labels Sep 30, 2022
@KristofferC
Copy link
Copy Markdown
Member

KristofferC commented Sep 30, 2022

Not sure who @admin is.

What do you advise?

The CI is not 100.00% reliable. If it is only the SparseMatrix tests on FreeBSD on a PR that is very unlikely to affect that then I think it is safe to say that the error is unlikely to be related to the PR.

@JeffreySarnoff
Copy link
Copy Markdown
Contributor Author

JeffreySarnoff commented Oct 3, 2022

Yes, It is only SparseMatrix. So, this is ready to merge. It would be good to merge it before the upcoming release.

@oscardssmith oscardssmith merged commit fcdc5bc into JuliaLang:master Oct 3, 2022
@KristofferC KristofferC mentioned this pull request Oct 27, 2022
Merged
37 tasks
KristofferC pushed a commit that referenced this pull request Oct 27, 2022
@JeffreySarnoff @KristofferC
bugfix: fld1 order of ops (#46938)
8c2b377 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@JeffreySarnoff @KristofferC
bugfix: fld1 order of ops (#46938)
b6353d1 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@JeffreySarnoff @KristofferC
bugfix: fld1 order of ops (#46938)
6caa013 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Nov 8, 2022
@KristofferC KristofferC mentioned this pull request Dec 21, 2022
Closed
78 tasks
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@JeffreySarnoff
bugfix: fld1 order of ops (#46938)
f14378f 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@JeffreySarnoff
bugfix: fld1 order of ops (#46938)
f6ebcc9 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@JeffreySarnoff
bugfix: fld1 order of ops (#46938)
1c1f63c 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Dec 21, 2022
@JeffreySarnoff
bugfix: fld1 order of ops (#46938)
e296fe7 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@JeffreySarnoff @staticfloat
bugfix: fld1 order of ops (#46938)
850a1f7 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
KristofferC pushed a commit that referenced this pull request Oct 10, 2023
@JeffreySarnoff @KristofferC
bugfix: fld1 order of ops (#46938)
bb60877 
* bugfix: fld1 order of ops

fixes #28973

(cherry picked from commit fcdc5bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport 1.6 Change should be backported to release-1.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fld1 is weird

3 participants

@JeffreySarnoff @oscardssmith @KristofferC