treat CartesianIndex as a broadcast scalar#47044
Merged
DilumAluthge merged 3 commits intomasterfrom Jan 28, 2023
Merged
Conversation
Member
Author
|
CI |
Member
Author
|
Ping @mbauman. |
stevengj
force-pushed
the
sgj/cartesianindex_scalar
branch
from
674351e to
0a6e294
Compare
Member
Author
|
Rebased. Marking as "triage" since this is a very simple PR and it would be good to get a decision. |
Member
|
I don't think we need triage here — this is pretty unobjectionable. Let's just do this! |
mbauman
approved these changes
Jan 26, 2023
stevengj
force-pushed
the
sgj/cartesianindex_scalar
branch
from
4775407 to
414026f
Compare
Member
Author
|
rebased |
DilumAluthge
removed
the
merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38432 and #41540.