Merged
Conversation
Member
Author
|
CI failures seem unrelated. (It would be nice to see a green CI again someday!) |
vtjnash
reviewed
Jan 22, 2023
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
Sounds sensible to me. Shall we merge this?
andreasnoack
approved these changes
Jan 22, 2023
Member
andreasnoack
left a comment
andreasnoack
left a comment
There was a problem hiding this comment.
Seems like a useful and uncontroversial extension.
DilumAluthge
removed
the
merge me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was pointed out on discourse that
binomial(x, k)has a perfectly sensible and standard meaning for non-integerxand integerk, where it is simply a polynomial inx.Since it can be implemented in only a few lines, a naive implementation overflows, and this can only be done in Base to avoid type piracy, it seems worthwhile adding.
(For non-integer
k, a generalization requires the Gamma function and/or the beta function, which is out of scope for Base. See also #14165 and JuliaMath/SpecialFunctions.jl#282)