force singlethreading during precompilation#48592
Merged
IanButterworth merged 2 commits intoJuliaLang:masterfrom Feb 10, 2023
Merged
force singlethreading during precompilation#48592IanButterworth merged 2 commits intoJuliaLang:masterfrom
IanButterworth merged 2 commits intoJuliaLang:masterfrom
Conversation
Member
Author
|
It seems the |
Member
Is this a separate bug that we should fix? |
Member
Author
|
Discussed on slack and it seems logical that it doesn't. |
JeffBezanson
approved these changes
Feb 8, 2023
Member
Author
|
@nanosoldier |
Collaborator
|
Your package evaluation job has completed - possible new issues were detected. |
Member
Author
|
pkgeval seems ok to me |
vtjnash
reviewed
Feb 10, 2023
| -`, | ||
| "OPENBLAS_NUM_THREADS" => 1), | ||
| "OPENBLAS_NUM_THREADS" => 1, | ||
| "JULIA_NUM_THREADS" => 1), |
Member
There was a problem hiding this comment.
"JULIA_NUM_THREADS" => nothing),
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2023
(cherry picked from commit c0d2c57)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2023
(cherry picked from commit c0d2c57)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2023
(cherry picked from commit c0d2c57)
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit c0d2c57)
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit c0d2c57)
KristofferC
pushed a commit
that referenced
this pull request
Feb 21, 2023
(cherry picked from commit c0d2c57)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only allowing 1 julia thread during precompiling packages makes sense in the context that
Pkg.precompilemanages multi-processing, and any multithreading during precompilation risks overloading the systemJULIA_IMAGE_THREADSenv var for controlling that multithreading, whichPkg.precompilewill be taught to manageAnd a niche issue:
incremental = falsemode causesPkg.precompileto overload all threads when multithreading PackageCompiler.jl#778A pkgeval run would probably be a good idea for this