Fix final gc lowering on dynamically sized allocation#48620
Merged
vchuravy merged 2 commits intoJuliaLang:masterfrom Feb 10, 2023
Merged
Fix final gc lowering on dynamically sized allocation#48620vchuravy merged 2 commits intoJuliaLang:masterfrom
vchuravy merged 2 commits intoJuliaLang:masterfrom
Conversation
Member
Author
|
This should be backported to 1.9 and earlier versions as well. |
oscardssmith
added
backport 1.8
vchuravy
reviewed
Feb 10, 2023
vchuravy
approved these changes
Feb 10, 2023
Member
|
Also can you try locally Line 3181 in 05b99af libjulia-internal.
|
Member
Author
|
|
oscardssmith
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2023
(cherry picked from commit 7e57dc7)
Member
|
I backported this but got an error in the llvmpasses: https://buildkite.com/julialang/julia-release-1-dot-9/builds/101#01866edd-e69e-4681-81ce-5585968bd21b. I'll drop it from the backport branch for now and either @wsmoses and @vchuravy can push a correct backport to those branches. |
vchuravy
pushed a commit
that referenced
this pull request
Mar 3, 2023
(cherry picked from commit 7e57dc7)
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2023
(cherry picked from commit 7e57dc7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves EnzymeAD/Enzyme.jl#553 and is hit during 1.9 on EnzymeAD/Enzyme.jl#597 aka #48621
cc @vchuravy @vtjnash