Revert "delay loading of extensions as much as possible (#48674)"#49257
Merged
KristofferC merged 2 commits intomasterfrom Apr 9, 2023
Merged
Revert "delay loading of extensions as much as possible (#48674)"#49257KristofferC merged 2 commits intomasterfrom
KristofferC merged 2 commits intomasterfrom
Conversation
oscardssmith
added
the
needs pkgeval
KristofferC
removed
the
needs pkgeval
KristofferC
force-pushed
the
kc/revert_ext_load
branch
from
c180044 to
4e9b963
Compare
KristofferC
force-pushed
the
kc/revert_ext_load
branch
3 times, most recently
from
67d11df to
a854387
Compare
KristofferC
force-pushed
the
kc/revert_ext_load
branch
from
a854387 to
aa16cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e3043a8 (#48674).
Fixes #49250
It was decided to disallow cycles in extensions but allow them to be loaded at precompile time.