Deprecate implicit pseudo-inverses of vectors#50955
Closed
antoine-levitt wants to merge 6 commits intoJuliaLang:masterfrom
Closed
Deprecate implicit pseudo-inverses of vectors#50955antoine-levitt wants to merge 6 commits intoJuliaLang:masterfrom
antoine-levitt wants to merge 6 commits intoJuliaLang:masterfrom
Conversation
Contributor
|
|
Contributor
Author
|
We can still send a signal "this function was a mistake, don't use it, and hypothetically if we ever get around to making breaking changes we'll remove it" |
dkarrasch
reviewed
Aug 30, 2023
Contributor
Author
|
Can we merge this? |
oscardssmith
approved these changes
Feb 22, 2024
Member
|
We have moved the LinearAlgebra stdlib to an external repo: https://github.com/JuliaLang/LinearAlgebra.jl @antoine-levitt If you think that this PR is still relevant, please open a new PR on the LinearAlgebra.jl repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #49915. If we can't remove it, at least let's deprecate it. I'm still not super happy about it because deprecations aren't shown by default, but it's better than nothing.
Note that this now deprecates all pseudo-inverses, eg vector \ vector, unlike the previous PR that just removed real / vector.