Fix goto insertion when dom-sorting IR in slot2ssa pass#56189
Merged
oscardssmith merged 1 commit intoJuliaLang:masterfrom Oct 18, 2024
Merged
Fix goto insertion when dom-sorting IR in slot2ssa pass#56189oscardssmith merged 1 commit intoJuliaLang:masterfrom
goto insertion when dom-sorting IR in slot2ssa pass#56189oscardssmith merged 1 commit intoJuliaLang:masterfrom
Conversation
This code wasn't fully handling fall-through terminators that cannot have their BasicBlock extended.
oscardssmith
added
bugfix
vtjnash
reviewed
Oct 16, 2024
Member
|
Unfortunately this doesn't seem to fix #55388 . |
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
Member
Author
|
Yeah, domsorting happens at the very end of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-up this pass a bit to correctly handle fall-through terminators that cannot have their BasicBlock extended
(e.g.
Expr(:leave, ...))