Fix kron indexing for types without a unique zero#56229
Merged
Conversation
jishnub
added
linear algebra
KristofferC
pushed a commit
that referenced
this pull request
Oct 21, 2024
This fixes a bug introduced in #55941. We may also take this opportunity to limit the scope of the `@inbounds` annotations, and also use `axes` to compute the bounds instead of hard-coding them. The real "fix" here is on line 767, where `l in 1:nA` should have been `l in 1:mB`. Using `axes` avoids such errors, and makes the operation safer as well.
KristofferC
pushed a commit
that referenced
this pull request
Oct 29, 2024
This fixes a bug introduced in #55941. We may also take this opportunity to limit the scope of the `@inbounds` annotations, and also use `axes` to compute the bounds instead of hard-coding them. The real "fix" here is on line 767, where `l in 1:nA` should have been `l in 1:mB`. Using `axes` avoids such errors, and makes the operation safer as well. (cherry picked from commit b01095e)
Member
|
Does this fix the segfault reported in #55941 (comment)? If so, this should be backported to 1.10 since #55941 is marked for backport |
Member
Author
|
Yes this fixes the segfault. I've removed the backport label on #55941, since, in hindsight, this was not exactly a bugfix. |
KristofferC
removed
the
backport 1.11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced in #55941.
We may also take this opportunity to limit the scope of the
@inboundsannotations, and also useaxesto compute the bounds instead of hard-coding them.The real "fix" here is on line 767, where
l in 1:nAshould have beenl in 1:mB. Usingaxesavoids such errors, and makes the operation safer as well.