Switch from MbedTLS to OpenSSL by eschnett · Pull Request #56708 · JuliaLang/julia

eschnett · 2024-11-28T16:45:34Z

Based on @fxcoudert's openssl branch and pull request at #53891.

diff re-applied to current Julia master (hence the new commit)
LibCURL, LibGit2, LibSSH2, OpenSSL updated to newest version
MbedTLS removed

@fxcoudert

Based on @fxcoudert's openssl branch and pull request at JuliaLang#53891. - diff re-applied to current Julia master (hence the new commit) - LibCURL, LibGit2, LibSSH2, OpenSSL updated to newest version - MbedTSL removed

eschnett · 2024-11-28T21:47:08Z

Current to-do list:

Understand how NetworkOptions and OpenSSL cooperate regarding CA roots. Possibly remove all NetworkOptions stuff from the OpenSSL_jll stdlib.
NetworkOptions has some MbedTLS-specific code. This needs to be switched to OpenSSL.
I added some OpenSSL CA-root work-around into the test cases. That should probably be removed again.
Something is off with LibCURL. We need to decide what to do, at the moment likely just staying at an older version.

giordano · 2024-11-28T22:04:34Z

Something is off with LibCURL. We need to decide what to do, at the moment likely just staying at an older version.

If you mean with libcurl v8.10+ JuliaLang/Downloads.jl#260, JuliaLang/Downloads.jl#260 (comment) should fix it. But there are still other failures: JuliaLang/Downloads.jl#261

eschnett · 2024-11-29T18:13:58Z

This PR requires the two other PRs

Currently these other PRs are hardcoded in stdlib/NetworkOptions.version and Pkg.version. That also needs to be undone.

eschnett · 2024-11-29T19:57:32Z

@giordano There is a likely-spurious test failure. Can you restart test x86_64-unknown-freebsd?

deps/checksums/SuiteSparse-e8285dd13a6d5b5cf52d8124793fc4d622d07554.tar.gz/md5

deps/checksums/clang

deps/checksums/llvm

deps/checksums/suitesparse

deps/checksums/unwind

deps/curl.mk

deps/checksums/Pkg-05df5cb52a60672120f84ce0cb0edaf053ebfbae.tar.gz/md5

fxcoudert · 2025-01-04T17:09:10Z

Single failure in test x86_64-apple-darwin, codegen:

Compiler/codegen                                 (3) |        started at 2025-01-04T08:05:48.661
      From worker 3:	WARNING: method definition for f56739 at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-grannysmith-C07ZQ07RJYVY.0/build/default-grannysmith-C07ZQ07RJYVY-0/julialang/julia-master/julia-8bb516f20e/share/julia/Compiler/test/codegen.jl:1034 declares type variable T but does not use it.
Compiler/codegen                                 (3) |         failed at 2025-01-04T08:07:22.987
Test Failed at /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-grannysmith-C07ZQ07RJYVY.0/build/default-grannysmith-C07ZQ07RJYVY-0/julialang/julia-master/julia-8bb516f20e/share/julia/Compiler/test/codegen.jl:412
  Expression: abs(#= /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-grannysmith-C07ZQ07RJYVY.0/build/default-grannysmith-C07ZQ07RJYVY-0/julialang/julia-master/julia-8bb516f20e/share/julia/Compiler/test/codegen.jl:412 =# @allocated(f_dict_hash_alloc()) / #= /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-grannysmith-C07ZQ07RJYVY.0/build/default-grannysmith-C07ZQ07RJYVY-0/julialang/julia-master/julia-8bb516f20e/share/julia/Compiler/test/codegen.jl:412 =# @allocated(g_dict_hash_alloc()) - 1) < 0.1
   Evaluated: 0.3193392980041294 < 0.1

giordano · 2025-01-04T17:11:45Z

That's #56748

* Curl was missing a dependency on OpenSSL after JuliaLang#56708 * openssl is missing configuration target for riscv64

* Curl was missing a dependency on OpenSSL after #56708 * openssl is missing configuration target for riscv64

eschnett added 9 commits November 28, 2024 11:45

Switch from MbedTLS to OpenSSL

bf4a023

Based on @fxcoudert's openssl branch and pull request at JuliaLang#53891. - diff re-applied to current Julia master (hence the new commit) - LibCURL, LibGit2, LibSSH2, OpenSSL updated to newest version - MbedTSL removed

Update dependency checksums

1361539

Add openssl checksums

6dcf771

stdlib: Update Manifest.toml

2eaf9e7

Use curl 8.9.1

0c71d23

Update Manifests

2dddd78

Add LibCURL checksums

1538fdc

Merge branch 'master' into eschnett/openssl

e42eac4

Wiggle OpenSSL tests

cd9df42

eschnett requested review from StefanKarpinski and giordano November 28, 2024 21:22

eschnett added 2 commits November 28, 2024 20:42

Update sha1 and tests

117e762

Update NetworkOptions

e74bd3c

eschnett mentioned this pull request Nov 29, 2024

Enable OpenSSL certificates JuliaLang/NetworkOptions.jl#36

Merged

eschnett added 5 commits November 28, 2024 20:59

Update checksums

5fd5ce1

Add NetworkOptions tarball url

2ab1e7d

Update checksums

2cc9b32

Remove file

f5400d9

Update checksums

a22c365

eschnett mentioned this pull request Nov 29, 2024

Update Manifest to avoid MbedTLS_jll JuliaLang/Pkg.jl#4100

Closed

Update Pkg.jl

cef9458

eschnett mentioned this pull request Nov 29, 2024

Try migration to OpenSSL #53891

Closed

giordano reviewed Nov 29, 2024

View reviewed changes

giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries stdlib Julia's standard library labels Nov 29, 2024

IanButterworth reviewed Dec 30, 2024

View reviewed changes

deps/checksums/Pkg-05df5cb52a60672120f84ce0cb0edaf053ebfbae.tar.gz/md5 Outdated Show resolved Hide resolved

deps: Remove outdated Pkg checksums

39390ea

This comment has been minimized.

Sign in to view

Merge branch 'master' into eschnett/openssl

41bed40

eschnett mentioned this pull request Dec 31, 2024

Drop mbedTLS and migrate to OpenSSL #48799

Closed

This comment has been minimized.

Sign in to view

IanButterworth mentioned this pull request Dec 31, 2024

Check source path is found when getting package_info JuliaLang/Pkg.jl#4126

Merged

This comment has been minimized.

Sign in to view

Merge branch 'master' into eschnett/openssl

7f8f587

This comment has been minimized.

Sign in to view

IanButterworth mentioned this pull request Jan 1, 2025

Fix OpenSSL_jll detection JuliaLang/Pkg.jl#4127

Merged

IanButterworth and others added 3 commits January 1, 2025 19:49

Merge branch 'master' into eschnett/openssl

106cf9f

Merge branch 'master' into eschnett/openssl

b787dbf

Drop NetworkOptions checksums

8bb516f

giordano approved these changes Jan 4, 2025

View reviewed changes

giordano added the merge me PR is reviewed. Merge when all tests are passing label Jan 4, 2025

giordano merged commit 638dacc into JuliaLang:master Jan 4, 2025

giordano removed the merge me PR is reviewed. Merge when all tests are passing label Jan 4, 2025

fxcoudert mentioned this pull request Jan 4, 2025

Drop mbedTLS (and support BoringSSL (and HTTP/3)) #45856

Closed

giordano added a commit to giordano/julia that referenced this pull request Jan 5, 2025

[deps] Fix build systems of curl and openssl

bd7d5d6

* Curl was missing a dependency on OpenSSL after JuliaLang#56708 * openssl is missing configuration target for riscv64

giordano mentioned this pull request Jan 5, 2025

[deps] Fix build systems of curl and openssl #56960

Merged

giordano added a commit that referenced this pull request Jan 5, 2025

[deps] Fix build systems of curl and openssl (#56960)

89afe20

* Curl was missing a dependency on OpenSSL after #56708 * openssl is missing configuration target for riscv64

Uh oh!

Conversation

eschnett commented Nov 28, 2024 • edited by giordano Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eschnett commented Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

giordano commented Nov 28, 2024

Uh oh!

eschnett commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eschnett commented Nov 29, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

fxcoudert commented Jan 4, 2025

Uh oh!

giordano commented Jan 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

eschnett commented Nov 28, 2024 •

edited by giordano

Loading

eschnett commented Nov 28, 2024 •

edited

Loading

eschnett commented Nov 29, 2024 •

edited

Loading