fix generated_body_to_codeinfo to avoid string (which is not always defined)#57925
Merged
IanButterworth merged 1 commit intomasterfrom Apr 4, 2025
Merged
fix generated_body_to_codeinfo to avoid string (which is not always defined)#57925IanButterworth merged 1 commit intomasterfrom
string (which is not always defined)#57925IanButterworth merged 1 commit intomasterfrom
Conversation
Member
|
Can we add a test that we get the right error? |
Member
Author
|
I wasn't certain how, without testing/relying pretty heavily on what seemed like implementation details, since this seemed pretty specifically an implementation issue with just the |
Member
|
I think just doing the |
…efined) Fixes a discrepancy between the code in C before #57230 and in Julia afterwards, making sure to sequence these definitions correctly. Not sure how to write a reliable test since it is specific to when this generated function is defined relative to the helpers used by this thunk, but the issue/fix is visible with: ``` $ ./julia -e 'code_lowered(ntuple, (Returns{Nothing}, Val{1000000}))' ```
oscardssmith
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Apr 4, 2025
… defined) (#57925) Fixes a discrepancy between the code in C before #57230 and in Julia afterwards, making sure to sequence these method definitions correctly. Not sure how to write a reliable test since it is specific to when this generated function is defined relative to the helpers used by this thunk, but the issue/fix is visible with: ``` $ ./julia -e 'code_lowered(ntuple, (Returns{Nothing}, Val{1000000}))' ``` Fix #57301 (cherry picked from commit a3c48d7)
51 tasks
KristofferC
removed
the
backport 1.12
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a discrepancy between the code in C before #57230 and in Julia afterwards, making sure to sequence these method definitions correctly. Not sure how to write a reliable test since it is specific to when this generated function is defined relative to the helpers used by this thunk, but the issue/fix is visible with:
Fix #57301