Add Compiler._verify_trim_world_age for better printing#58407
Merged
topolarity merged 1 commit intoJuliaLang:masterfrom May 13, 2025
Merged
Add Compiler._verify_trim_world_age for better printing#58407topolarity merged 1 commit intoJuliaLang:masterfrom
Compiler._verify_trim_world_age for better printing#58407topolarity merged 1 commit intoJuliaLang:masterfrom
Conversation
The `juliac-buildscript` is quite aggressive in how it modifies type
printing, so caching the pre-buildscript world like this allows us
to print stacktraces in their usual fidelity.
Before:
```
[1] get_size_dict!(ne::StaticNestedEinsum{Char, ?, ?}, xs::Any, size_info::Dict{Char, Int64})
@ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
...
```
After:
```
[1] get_size_dict!(ne::StaticNestedEinsum{Char, nothing, ('j','k','l')}, xs::Any, size_info::Dict{Char, Int64})
@ OMEinsum ~/.julia/dev/OMEinsum/src/einsequence.jl:269
...
```
topolarity
added
trimming
vtjnash
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
juliac-buildscriptis quite aggressive in how it modifies type printing, so caching the pre-buildscript world like this allows us to print stacktraces in their usual fidelity.Before:
After: