[OpenBLAS_jll] Include patches to fix CASUM in 1.10#59346
[OpenBLAS_jll] Include patches to fix CASUM in 1.10#59346ViralBShah merged 2 commits intoJuliaLang:backports-release-1.10from
Conversation
* Backport patch to use AVX512 kernels on modern processors * Backport patch that fixes incorrect CASUM computation in fallback kernel
|
The build is failing on linux. |
|
It is showing this error: which shouldn't be a consequence of this PR. It looks like that is a consequence of 7a28ad5 being backported without the BFloat16 define - cc @gbaraldi. |
|
@imciner2 Is this issue only on 1.10? This is severe enough to require a new 1.10 release, and the original issue suggested that this did not happen on 1.11 (and hence unlikely on 1.12 also). |
You mean the linear algebra issue here? This is only in OpenBLAS pre-0.3.25(ish), and 1.11+ are all on newer versions than that, so they aren't affected. The original reporter even compared against 1.11 in the initial report to show it was broken and somehow fixed. |
|
The errors are now the same test failures as on the branch normally, so they aren't caused by this change. It should be good to merge. |
I think that this statement is correct. On
On this PR, I see the above three failures. But I also see the following on this PR only:
However, I suspect that the |
|
After a retry, Per #59346 (comment), it seems that the failures on this PR are the same failures that already exist on @ViralBShah Is this good to merge? |
1a3c229
into
JuliaLang:backports-release-1.10
|
We should probably kick off a new release to include this. |
It's in progress. #58889 |
I'll run the backports script again either today or this weekend. |
|
@ViralBShah, you added the 1.12 backport label but 1.12 is on OpenBLAS 0.3.29 so this should not be backported to there, I guess? Based on
I'll remove the backport label. |
|
Yeah, I must have done that in error. I believe it was only needed on 1.10 and not later. |
This updates 1.10 to contain two new OpenBLAS patches that come from upstream (they are included in newer OpenBLAS versions already). Specifically the patches do:
This fixes the reported linear algebra issue: JuliaLang/LinearAlgebra.jl#1406.
I believe I updated all the checksums/files to make this work, specifically I did
stdlib/OpenBLAS_jll/Project.tomldeps/openblas.versionmake -f contrib/refresh_checksums.mk -j openblascc @giordano, @ViralBShah