[backports-release-1.11]: Revert "fix null comparisons for non-standard address spaces (#58837)"#59445
Merged
DilumAluthge merged 1 commit intobackports-release-1.11from Aug 31, 2025
Conversation
This reverts commit 3b04664.
DilumAluthge
changed the title
backports-release-1.11]: Revert "fix null comparisons for non-standard address spaces (#58837)"
Member
Author
Member
|
Can we backport #59259 instead? Can't test it right now, but it should fix these issues |
Member
Author
Sure, let's try that out. I'll make a separate PR first, and if that works, then we can add the backport label so that Kristoffer's script does the backport. |
Member
Author
Member
Author
|
#59446 doesn't seem to be sufficient. Can we proceed with this revert for now, and then we can try to re-land later? |
simeonschaub
approved these changes
Aug 31, 2025
Member
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Seems ok for now, seeing as the AMDGPU issues were only observed on 1.12+
Member
Author
|
Windows failures are errors when cleaning up temp directories.
|
gbaraldi
added a commit
that referenced
this pull request
Sep 9, 2025
…ion for null ptr comparisons") to Julia 1.11.x (#59446) Backports #59259 to 1.11 (cherry picked from commit 920df7a). For more details, see #59445 (comment). Targets `backports-release-1.11` (#59336). --------- Co-authored-by: Gabriel Baraldi <baraldigabriel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 3b04664 (which backports #58837 to 1.11.x).
For more details, see #59336 (comment) and #59336 (comment).
Targets
backports-release-1.11(#59336).