fix potential null deref in merge_vararg_unions#59525
Merged
vtjnash merged 2 commits intoJuliaLang:masterfrom Sep 10, 2025
Merged
fix potential null deref in merge_vararg_unions#59525vtjnash merged 2 commits intoJuliaLang:masterfrom
merge_vararg_unions#59525vtjnash merged 2 commits intoJuliaLang:masterfrom
Conversation
adienes
added
types and dispatch
Seelengrab
reviewed
Sep 10, 2025
| @test !(Tuple{Int,Vararg{Int,2}} <: Tuple{Int,Int,Int,Vararg{Int,1}}) | ||
| @test Tuple{Int,Vararg{Int}} == Tuple{Int,Vararg{Int}} | ||
| @test (@UnionAll N Tuple{Int,Vararg{Int,N}}) == (@UnionAll N Tuple{Int,Vararg{Int,N}}) | ||
| @test Union{Tuple{}, Tuple{Int}, Tuple{UInt}} <: Union{ |
Contributor
There was a problem hiding this comment.
Suggested change
| @test Union{Tuple{}, Tuple{Int}, Tuple{UInt}} <: Union{ | |
| # This is a regression test against a nullcheck/segfault in jltypes.c | |
| @test Union{Tuple{}, Tuple{Int}, Tuple{UInt}} <: Union{ |
Member
Author
There was a problem hiding this comment.
it's also a correct test, right? I mean I'm not opposed to such a comment per se it just seems maybe unnecessary, especially since the cause of the crash is "typo" not "design failure"
Member
There was a problem hiding this comment.
Preferably it would have been added to the list of tests for this function, with a comment noting the issue number or PR, though both are commonly extracted from git praise anyways d4362e4#diff-90c3a7a047872b9929e6577e16ad589a77552d0de0400c98cf303b6b7204e683R8257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so as to avoid segfaults in the following type normalization