[tests] Fix an invalidation test in the precompile testset (extracted out of #59413)#59879
Merged
DilumAluthge merged 2 commits intomasterfrom Oct 18, 2025
Merged
[tests] Fix an invalidation test in the precompile testset (extracted out of #59413)#59879DilumAluthge merged 2 commits intomasterfrom
DilumAluthge merged 2 commits intomasterfrom
Conversation
DilumAluthge
added
test
Member
|
It isn't a Windows bug. The test is buggy, so it fails everywhere with equal probability. The fix is also ready, since it is just an edit to this test |
Member
Author
|
Ah, I misunderstood, I thought the entirety of #59413 was needed for the fix. I'll cherry-pick the fix out. |
DilumAluthge
changed the title
DilumAluthge
force-pushed
the
DilumAluthge-patch-1
branch
from
7a88a4a to
e18f75c
Compare
Member
Author
This is done. |
vtjnash
approved these changes
Oct 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59846
Extracted out of #59413
Previous description:
Ref #59846.It's not helpful to have this test frequently failing on Windows and causing noise.The fix (#59413) isn't ready yet, so let's skip (on Windows) for now, and we can stop skipping once the fix lands.