Skip to content

reflection: enable Base._which with non-base Compiler.MethodTableView#59915

Merged
aviatesk merged 1 commit intomasterfrom
avi/invoke_mt_compiler
Oct 21, 2025
Merged

reflection: enable Base._which with non-base Compiler.MethodTableView#59915
aviatesk merged 1 commit intomasterfrom
avi/invoke_mt_compiler

Conversation

@aviatesk
Copy link
Copy Markdown
Member

When packages using non-Base compilers call Base._which, a method error occurs due to module context mismatch. Like other reflection functions, the module context of mt::Compiler.MethodTableView needs to be properly determined.

`Compiler.MethodTableView`

When packages using non-Base compilers call `Base._which`, a method
error occurs due to module context mismatch. Like other reflection
functions, the module context of `mt::Compiler.MethodTableView` needs to
be properly determined.
@aviatesk aviatesk requested a review from Keno October 20, 2025 12:41
@aviatesk aviatesk added the backport 1.12 Change should be backported to release-1.12 label Oct 20, 2025
@KristofferC KristofferC mentioned this pull request Oct 21, 2025
35 tasks
@aviatesk aviatesk merged commit 493d72d into master Oct 21, 2025
7 of 9 checks passed
@aviatesk aviatesk deleted the avi/invoke_mt_compiler branch October 21, 2025 13:23
aviatesk added a commit that referenced this pull request Oct 21, 2025
…iew` (#59915)

When packages using non-Base compilers call `Base._which`, a method
error occurs due to module context mismatch. Like other reflection
functions, the module context of `mt::Compiler.MethodTableView` needs to
be properly determined.
@aviatesk aviatesk removed the backport 1.12 Change should be backported to release-1.12 label Oct 21, 2025
DilumAluthge pushed a commit that referenced this pull request Nov 5, 2025
…iew` (#59915)

When packages using non-Base compilers call `Base._which`, a method
error occurs due to module context mismatch. Like other reflection
functions, the module context of `mt::Compiler.MethodTableView` needs to
be properly determined.
aviatesk added a commit to JuliaDebug/CassetteOverlay.jl that referenced this pull request Nov 12, 2025
Since JuliaLang/julia#59915, `Base._which` now takes
`Compiler.MethodTableView` instead of `MethodTable`, so this change is
necessary.

However, with this change, it seems that CassetteOverlay and external
abstract interpreter packages cannot be composed. If this becomes
necessary, we may need to change the interface of
`CassetteOverlay.method_table`.
aviatesk added a commit to JuliaDebug/CassetteOverlay.jl that referenced this pull request Nov 13, 2025
Since JuliaLang/julia#59915, `Base._which` now takes
`Compiler.MethodTableView` instead of `MethodTable`, so this change is
necessary.

However, with this change, it seems that CassetteOverlay and external
abstract interpreter packages cannot be composed. If this becomes
necessary, we may need to change the interface of
`CassetteOverlay.method_table`.
aviatesk added a commit to JuliaDebug/CassetteOverlay.jl that referenced this pull request Nov 13, 2025
Since JuliaLang/julia#59915, `Base._which` now takes
`Compiler.MethodTableView` instead of `MethodTable`, so this change is
necessary.

However, with this change, it seems that CassetteOverlay and external
abstract interpreter packages cannot be composed. If this becomes
necessary, we may need to change the interface of
`CassetteOverlay.method_table`.
aviatesk added a commit to JuliaDebug/CassetteOverlay.jl that referenced this pull request Nov 13, 2025
Since JuliaLang/julia#59915, `Base._which` now takes
`Compiler.MethodTableView` instead of `MethodTable`, so this change is
necessary.

However, with this change, it seems that CassetteOverlay and external
abstract interpreter packages cannot be composed. If this becomes
necessary, we may need to change the interface of
`CassetteOverlay.method_table`.
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jan 21, 2026
…iew` (JuliaLang#59915)

When packages using non-Base compilers call `Base._which`, a method
error occurs due to module context mismatch. Like other reflection
functions, the module context of `mt::Compiler.MethodTableView` needs to
be properly determined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant