Skip to content

REPL: make interactive precompiles test more robust#60006

Merged
IanButterworth merged 4 commits intoJuliaLang:masterfrom
IanButterworth:ib/repl_test
Nov 1, 2025
Merged

REPL: make interactive precompiles test more robust#60006
IanButterworth merged 4 commits intoJuliaLang:masterfrom
IanButterworth:ib/repl_test

Conversation

@IanButterworth
Copy link
Copy Markdown
Member

@IanButterworth IanButterworth added backport 1.12 Change should be backported to release-1.12 backport 1.13 Change should be backported to release-1.13 labels Oct 31, 2025
@IanButterworth IanButterworth added merge me PR is reviewed. Merge when all tests are passing and removed merge me PR is reviewed. Merge when all tests are passing labels Oct 31, 2025
@IanButterworth
Copy link
Copy Markdown
Member Author

Still failing here.

@IanButterworth
Copy link
Copy Markdown
Member Author

The issue on macOS x86 is we're hitting REPL precompilation...


From worker 4:	┌ Info: There was output before the julia prompt:
--
  | From worker 4:	│ [ Info: Precompiling REPL [3fa0cd96-eef1-5676-8a61-b3b8758bbffb] (cache misses: mismatched flags (1))
  | From worker 4:	│ Precompiling packages...
  | From worker 4:	│  214334.6 ms  ✓ REPL (serial)
  | From worker 4:	│   1 dependency successfully precompiled in 215 seconds
  |  
  | From worker 4:	┌ Info: REPL: trace compile output:
  | From worker 4:	│ precompile(Tuple{FileWatching.Pidfile.var"##mkpidlock#8", Base.Pairs{Symbol, Integer, Nothing, NamedTuple{(:stale_age, :wait), Tuple{Int64, Bool}}}, typeof(FileWatching.Pidfile.mkpidlock), Base.var"#__require_prelocked##0#__require_prelocked##1"{Base.PkgId, String, Base.Dict{String, Int64}}, String, Int32})
  | From worker 4:	│ precompile(Tuple{typeof(Base.CoreLogging.shouldlog), Base.CoreLogging.ConsoleLogger, Base.CoreLogging.LogLevel, Module, Symbol, Symbol})
  | From worker 4:	│ precompile(Tuple{typeof(Core.kwcall), NamedTuple{(:context,), Tuple{Nothing}}, typeof(Base.repr), Base.Multimedia.MIME{:var"text/plain"}, Base.PkgId})
  | From worker 4:	│ precompile(Tuple{typeof(Base.isopen), Base.GenericIOBuffer{Memory{UInt8}}})
  | From worker 4:	│ precompile(Tuple{Type{Base.IOContext{IO_t} where IO_t<:IO}, Base.GenericIOBuffer{Memory{UInt8}}, Base.TTY})
  | From worker 4:	│ precompile(Tuple{typeof(Base.write), Base.TTY, Array{UInt8, 1}})
  | From worker 4:	│ precompile(Tuple{typeof(Base.Precompilation.can_fancyprint), Base.TTY})
  | From worker 4:	│ precompile(Tuple{Base.Precompilation.var"##precompilepkgs#9", Bool, Bool, Bool, Bool, Bool, Pair{Base.Cmd, Base.CacheFlags}, Base.TTY, Bool, Bool, Bool, typeof(Base.Precompilation.precompilepkgs), Array{Base.PkgId, 1}})
  | From worker 4:	│ precompile(Tuple{typeof(Base.iterate), Array{Base.PkgId, 1}})
  | From worker 4:	│ precompile(Tuple{typeof(Base.haskey), Base.Dict{Base.PkgId, Array{Base.PkgId, 1}}, Base.PkgId})
  | From worker 4:	│ precompile(Tuple{typeof(Base.iterate), Array{Base.PkgId, 1}, Int64})
  | From worker 4:	│ precompile(Tuple{typeof(Base.Precompilation.printpkgstyle), Base.IOContext{IO}, Symbol, String})
  | From worker 4:	│ precompile(Tuple{typeof(Base.lock), Base.TTY})
  | From worker 4:	│ precompile(Tuple{typeof(Base.unlock), Base.TTY})
  | From worker 4:	└ precompile(Tuple{typeof(Base.println), Base.IOContext{IO}, String, String, Vararg{String}})


Copy link
Copy Markdown
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Nov 1, 2025
@IanButterworth IanButterworth merged commit a933cf4 into JuliaLang:master Nov 1, 2025
8 checks passed
@IanButterworth IanButterworth deleted the ib/repl_test branch November 1, 2025 10:45
KristofferC pushed a commit that referenced this pull request Nov 5, 2025
@KristofferC KristofferC mentioned this pull request Nov 5, 2025
17 tasks
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 6, 2025
KristofferC pushed a commit that referenced this pull request Nov 7, 2025
@KristofferC KristofferC mentioned this pull request Nov 7, 2025
35 tasks
@KristofferC KristofferC removed the backport 1.12 Change should be backported to release-1.12 label Nov 21, 2025
@KristofferC KristofferC removed the backport 1.13 Change should be backported to release-1.13 label Nov 28, 2025
kpamnany pushed a commit to RelationalAI/julia that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants