Parametrize struct definitions of random matrix ensemble types#96
Parametrize struct definitions of random matrix ensemble types#96apkille wants to merge 1 commit intoJuliaMath:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 42.65% 42.65%
=======================================
Files 12 12
Lines 830 830
=======================================
Hits 354 354
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dlfivefifty ping for review |
| GaussianHermite(β) = GaussianHermite{β}() | ||
| struct GaussianHermite{B} <: ContinuousMatrixDistribution | ||
| beta::B | ||
| end |
There was a problem hiding this comment.
I’m not sure this change is a good idea since GUE, GOE, and GSE are very different and should be different types.
for general β this makes sense. Though my personal preference would be to use Unicode
There was a problem hiding this comment.
That's fair, I'll revert this. I guess with that in mind, would it be good to parametrize other ensemble types this way, e.g. Ginibre{4}?
There was a problem hiding this comment.
I think so. Especially if the code consists of a lot of special cases if β == 1, elseif β ==2, elseif β == 4 end then that hints that they actually should be treated as different types via parameterisation
2 participants
See #91.