Skip to content

[mbedtls] New version v2.28.1010: upstream 2.28.10 + Debian's (2.16.9) security patches#12380

Merged
giordano merged 13 commits into
JuliaPackaging:masterfrom
mbauman:mb/mbed-security
Nov 20, 2025
Merged

[mbedtls] New version v2.28.1010: upstream 2.28.10 + Debian's (2.16.9) security patches#12380
giordano merged 13 commits into
JuliaPackaging:masterfrom
mbauman:mb/mbed-security

Conversation

@mbauman
Copy link
Copy Markdown
Contributor

@mbauman mbauman commented Oct 23, 2025

The goal here is to address the CVEs: CVE-2025-47917, CVE-2025-48965, CVE-2025-52496, and CVE-2025-52497.

The most important diff to review is the re-landing of the patches to v2.28.10. These ranged in difficulty to an automatic three-way merge to completely manual re-implementation. That's 5f20384.

My process here was the fairly simple:

git am -3 $patch
# fixup
git format-patch HEAD~..HEAD --output=$patch

@mbauman mbauman marked this pull request as draft October 24, 2025 13:31
@mbauman
Copy link
Copy Markdown
Contributor Author

mbauman commented Oct 24, 2025

Welp, looks like the msan failures pre-date these patches. It'd be good to address them, but most are in the test suite itself.

image

@mbauman mbauman marked this pull request as ready for review October 24, 2025 19:42
@mbauman mbauman changed the title Build mbedtls v2.28.10 with Debian's security patches [mbedtls] New version v2.28.1010: upstream 2.28.10 + Debian's (2.16.9) security patches Oct 24, 2025
@mbauman
Copy link
Copy Markdown
Contributor Author

mbauman commented Oct 24, 2025

OK, still outstanding are last week's CVE-2025-54764 and CVE-2025-59438. There are suggested commits for backports there, but I'm guessing those will be more challenging.

@giordano
Copy link
Copy Markdown
Member

Is this good to go now?

@giordano giordano added the julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies label Oct 25, 2025
@mbauman
Copy link
Copy Markdown
Contributor Author

mbauman commented Oct 25, 2025

Let’s give it a bit here. I’d value any extra eyes on the diff^2s, and I’m gonna give a shot at backports for those other two issues.

@topolarity
Copy link
Copy Markdown
Member

topolarity commented Oct 30, 2025

You will probably need to tag someone in particular if you'd like additional review - there don't tend to be a lot of casual eyes combing Yggdrasil (except our beloved @giordano )

@mbauman
Copy link
Copy Markdown
Contributor Author

mbauman commented Nov 20, 2025

OK, I tried a few different ways to cherry-pick the patches for CVE-2025-54764 and CVE-2025-59438, but they are highly challenging. I've not seen any other ecosystem successfully backport those to v2.x, nor has anyone else pitched in on their mailing-list. Let's not let these hold up the other fixes.

I've also re-reviewed the diff² here and am pretty happy with the state of this PR.

Shall we merge this?

@giordano giordano merged commit 5d527ec into JuliaPackaging:master Nov 20, 2025
17 checks passed
@mbauman mbauman deleted the mb/mbed-security branch November 20, 2025 20:25
DilumAluthge added a commit to JuliaLang/julia that referenced this pull request Feb 2, 2026
…60744)

This PR bumps MbedTLS on Julia 1.10 to
[2.28.1010](JuliaPackaging/Yggdrasil#12380),
which is upstream 2.28.10 plus Debian's (2.16.9) security patches.

### Check list (from the
[devdocs](https://docs.julialang.org/en/v1.12/devdocs/build/build/#Update-the-version-number-of-a-dependency))

Version numbers:
- [x] `deps/$(libname).version`: `LIBNAME_VER`, `LIBNAME_BRANCH`,
`LIBNAME_SHA1` and `LIBNAME_JLL_VER`
- [x] `stdlib/$(LIBNAME_JLL_NAME)_jll/Project.toml`: `version`

Checksum:
- [x] `deps/checksums/$(libname)`
- [ ] `deps/checksums/$(LIBNAME_JLL_NAME)-*/`: `md5` and `sha512`
- I don't think this file exists anymore. It looks like the checksums
have been combined into `deps/checksums/mbedtls`.

Patches:
- [x] `deps/$(libname).mk`
- [x] `deps/patches/$(libname)-*.patch`

---------

Co-authored-by: Andy Dienes <51664769+adienes@users.noreply.github.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Eddie Groshev <eddie_g_89@hotmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Em Chu <61633163+mlechu@users.noreply.github.com>
Co-authored-by: Michiel Dral <m.c.dral@gmail.com>
Co-authored-by: Erik Schnetter <schnetter@gmail.com>
KristofferC added a commit to JuliaLang/julia that referenced this pull request Feb 2, 2026
…60744)

This PR bumps MbedTLS on Julia 1.10 to
[2.28.1010](JuliaPackaging/Yggdrasil#12380),
which is upstream 2.28.10 plus Debian's (2.16.9) security patches.

[devdocs](https://docs.julialang.org/en/v1.12/devdocs/build/build/#Update-the-version-number-of-a-dependency))

Version numbers:
- [x] `deps/$(libname).version`: `LIBNAME_VER`, `LIBNAME_BRANCH`,
`LIBNAME_SHA1` and `LIBNAME_JLL_VER`
- [x] `stdlib/$(LIBNAME_JLL_NAME)_jll/Project.toml`: `version`

Checksum:
- [x] `deps/checksums/$(libname)`
- [ ] `deps/checksums/$(LIBNAME_JLL_NAME)-*/`: `md5` and `sha512`
- I don't think this file exists anymore. It looks like the checksums
have been combined into `deps/checksums/mbedtls`.

Patches:
- [x] `deps/$(libname).mk`
- [x] `deps/patches/$(libname)-*.patch`

---------

Co-authored-by: Andy Dienes <51664769+adienes@users.noreply.github.com>
Co-authored-by: Ian Butterworth <i.r.butterworth@gmail.com>
Co-authored-by: Kristoffer Carlsson <kcarlsson89@gmail.com>
Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Co-authored-by: Max Horn <max@quendi.de>
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Eddie Groshev <eddie_g_89@hotmail.com>
Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Co-authored-by: Valentin Churavy <v.churavy@gmail.com>
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
Co-authored-by: Em Chu <61633163+mlechu@users.noreply.github.com>
Co-authored-by: Michiel Dral <m.c.dral@gmail.com>
Co-authored-by: Erik Schnetter <schnetter@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

julia 💜 ❤️ 💚 Builders and issues related to Julia and its dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants