Skip to content

Remove warmUpSolverJIT precompile#1014

Merged
Affie merged 1 commit intomasterfrom
24Q1/no_rome_precomp
Mar 1, 2024
Merged

Remove warmUpSolverJIT precompile#1014
Affie merged 1 commit intomasterfrom
24Q1/no_rome_precomp

Conversation

@Affie
Copy link
Copy Markdown
Member

@Affie Affie commented Mar 1, 2024

@dehann, can we remove warmUpSolverJIT as it should be precompiled with RoME.

@Affie Affie requested a review from dehann March 1, 2024 19:38
@Affie Affie self-assigned this Mar 1, 2024
@Affie
Copy link
Copy Markdown
Member Author

Affie commented Mar 1, 2024

haha, you are to fast for me, I was about to add labels and milestone

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 1, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.60%. Comparing base (08ddbf2) to head (c90ec4b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1014      +/-   ##
==========================================
- Coverage   27.63%   27.60%   -0.03%     
==========================================
  Files          54       54              
  Lines        2580     2579       -1     
==========================================
- Hits          713      712       -1     
  Misses       1867     1867              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Affie Affie merged commit cc5a2be into master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants