fix number of purity args on 1.11+#115
Conversation
topolarity
left a comment
There was a problem hiding this comment.
The new effects need to be tightened (as suggested) before this will be foldable, but LGTM 👍
Thanks!
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
Co-authored-by: Cody Tapscott <84105208+topolarity@users.noreply.github.com>
|
Thanks @chriselrod ! |
|
No problem! The auto-merge won't work while tests are failing. There were unfortunately some regressions that I never got around to looking at.
As of Julia 1.12, the tools will exist to drop RecursiveFactorization (and thus the JuliaSIMD ecosystem) from the SciML ecosystem by open sourcing a certain package (that requires LLVM17 for replacing RF), so folks will have to consider cost/benefit in the approach you take for getting important packages running on Julia >= 1.12. |
Fixes #114.