Skip to content

Use atol and rtol for default ctol #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmigot merged 1 commit into from
Apr 17, 2024
Merged

Use atol and rtol for default ctol #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/method.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ For advanced usage, first define a `PercivalSolver` to preallocate the memory us
- `x::V = nlp.meta.x0`: the initial guess;
- `atol::T = T(1e-8)`: absolute tolerance;
- `rtol::T = T(1e-8)`: relative tolerance;
- `ctol::T = T(1e-8)`: absolute tolerance on the feasibility;
- `ctol::T = atol > 0 ? atol : rtol`: absolute tolerance on the feasibility;
- `max_eval::Int = 100000`: maximum number of evaluation of the objective function;
- `max_time::Float64 = 30.0`: maximum time limit in seconds;
- `max_iter::Int = 2000`: maximum number of iterations;
Expand Down Expand Up @@ -302,7 +302,7 @@ function SolverCore.solve!(
max_eval::Int = 200000,
atol::Real = T(1e-8),
rtol::Real = T(1e-8),
ctol::Real = T(1e-8),
ctol::Real = atol > 0 ? atol : rtol,
subsolver_verbose::Int = 0,
cgls_verbose::Int = 0,
inity::Bool = false,
Expand Down