SparseMatrixCSC constructor with a Tuple of Integers#523
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 76.42% 76.42%
=======================================
Files 12 12
Lines 8967 8969 +2
=======================================
+ Hits 6853 6855 +2
Misses 2114 2114 ☔ View full report in Codecov by Sentry. |
Member
|
Merge? |
dkarrasch
pushed a commit
that referenced
this pull request
Nov 2, 2024
* SparseMatrixCSC constructor with a Tuple of Integers * SparseVector constructors --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
dkarrasch
pushed a commit
that referenced
this pull request
Nov 2, 2024
* SparseMatrixCSC constructor with a Tuple of Integers * SparseVector constructors --------- Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, the following works:
Previously, this used to call the
SparseMatrixCSCconstructor with aTupleofInts, which was not defined. Similar constructors are added forSparseVector.This should probably be backported to v1.11 as well as v1.10. I added the backport 1.10 label, but there doesn't seem to be one for v1.11.