test: Don't use GPL module when Base.USE_GPL_LIBS=false#535
test: Don't use GPL module when Base.USE_GPL_LIBS=false#535ViralBShah merged 6 commits intoJuliaSparse:mainfrom
Conversation
|
Is my understanding correct if I say that tests are failing because of method ambiguities between SparseArrays and LinearAlgebra when Aqua.jl runs? |
|
Should we disable the aqua tests until they run more reliably? |
Or run Aqua tests in a standalone CI job #537 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #535 +/- ##
==========================================
+ Coverage 84.05% 84.07% +0.01%
==========================================
Files 12 12
Lines 9020 9069 +49
==========================================
+ Hits 7582 7625 +43
- Misses 1438 1444 +6 ☔ View full report in Codecov by Sentry. |
|
Is this ok to merge? I assume we need to fix the Aqua tests separately (and those failures are not related to this PR). |
|
I don't think anything can cause failure, but it might be a good to also run the tests with USE_GPL_LIB=false... |
|
I believe the Aqua tests were running reliably. A commit on Julia master introduced method ambiguities that have been resolved meanwhile. They were failing even on the "split Aqua tests" PR. ;-) |
inkydragon
left a comment
There was a problem hiding this comment.
Apply suggestions.
The GPL module
SparseArrays.CHOLMODhas already been used before theif Base.USE_GPL_LIBSstatement.This results in the error