Break recursion

[wsmoses]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (07cf4a6) to head (dac0229).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   84.00%   84.04%   +0.03%     
==========================================
  Files          12       12              
  Lines        9172     9174       +2     
==========================================
+ Hits         7705     7710       +5     
+ Misses       1467     1464       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dkarrasch]

Is there a (simple) case that triggered indefinite recursion? Perhaps, we should add that as a test?

[wsmoses]

Extremely not reduced, but EnzymeAD/Enzyme.jl#1134

The issue was introduced by c402d09

cc @gbaraldi and @vtjnash who discussed soltuions with me yesterday

[wsmoses]

ping for a review. @gbaraldi confirmed it fixes the issue at hand

[ViralBShah]

PR for Julia: JuliaLang/julia#56531

[gbaraldi]

This also needs a backport to 1.11

[wsmoses]

and also to 1.10

[dkarrasch]

This also needs a backport to 1.11

WIP 298f5e1

[vtjnash]

Is there a (simple) case that triggered indefinite recursion?

There never was any, but Enzyme modeled the previous code wrong, resulting in crashes there:
EnzymeAD/Enzyme.jl#1134 (comment)