Merged
Conversation
Except where the declarations are disabled anyway with the pre-processor definition NOMORE_FOR_THREADS (which I don't know what it means).
Contributor
|
cc @devmotion @nalimilan @dmbates. I hope this is good. I have tagged v0.5.0 of this package, but wanted another pair of eyes before I kick off the BB etc. |
|
Looks fine to me but I am not that knowledgeable about multi-threaded C code. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The library uses a lot of non-const static variables, which break thread-safety. Several comments are in the code that forsee making those static variables
_Thread_localto allow using this library with threads.The changes in this PR make all non-const static variables (except those behind the pre-processor definition
NOMORE_FOR_THREADS)_Thread_local.This PR is just in case you don't want a patch but want to see the changes in a commit. According to the issue, contributions should be patch files? Here is the patch against
origin/masterdiff_origin_master.txt
fixes issue #46