Conversation
The tests for specific exception types in `sem` are relying on the exceptions thrown from deeper in the call stack, outside of this package's control. We do still expect these cases to throw, but since we can't actually control the type of the exception, we can instead test that any exception is thrown. The test of the number of allocations from calling `mad` on a generator fails because there are nearly 10x more allocations than the upper bound used in the test. We can mark this test broken with Julia v1.10, and the test will fail if the allocations for this case are improved, be it upstream or in the implementation of `mad` (if applicable).
Simply going from Documenter 0.24 to the latest, 0.27, fixes `makedocs` for me locally. This should fix the documentation build on CI.
Member
Author
This is so weird. I can reproduce it locally only if there is an existing |
Member
|
It seems the Documenter issue was fixed upstream (but is not available in 1.9 yet), so this shouldn't hold back the PR, should it? |
Member
Author
It sounds like the upstream change that fixed the issue with Documenter will not go into 1.9 (JuliaLang/julia#49975 (comment)).
Yeah I suppose not. I had forgotten about this PR but I believe at the time I figured I'd tackle CI issues together but the Documenter thing turned out to really be A Thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for specific exception types in
semare relying on the exceptions thrown from deeper in the call stack, outside of this package's control. We do still expect these cases to throw, but since we can't actually control the type of the exception, we can instead test that any exception is thrown.The test of the number of allocations from calling
madon a generator fails because there are nearly 10x more allocations than the upper bound used in the test. We can mark this test broken with Julia v1.10, and the test will fail if the allocations for this case are improved, be it upstream or in the implementation ofmad(if applicable).